From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Lukas Sichert" <l.sichert@proxmox.com>,
"Michael Köppl" <m.koeppl@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: Re: [PATCH cluster/docs/manager v2 0/8] add warning messages for high token timeouts in clusters
Date: Thu, 23 Apr 2026 15:59:01 +0200 [thread overview]
Message-ID: <DI0L6C6ZSLTV.HEVGMAXJJBI6@proxmox.com> (raw)
In-Reply-To: <DHZPFDZZE9LH.3KIJNLAG61ZAX@proxmox.com>
Thanks for having a look at this and testing!
On Wed Apr 22, 2026 at 3:06 PM CEST, Lukas Sichert wrote:
> I applied the patches and tested:
>
> - a small selection of links using `onlineHelp` still work
> - the new link using `get_help_link` jumps to the correct section
> - the correct messages are displayed in the cluster and UI if the
> `token_coefficient` is high enough
>
> One additional small nit not directly related to the changes in this
> commit, but closely related: the documentation does not mention which
> variable needs to be set for the token coefficient. While the name
> `token_coefficient` is quite intuitive, I think it would still be good
> to mention it explicitly, so one knows what to search for in the
> manpages.
@Friedrich is already working on that. Still, thanks for pointing it out!
>
> Since my comments are mostly minor, feel free to include my `Tested-by`
> in v3.
>
> Tested-by: Lukas Sichert <l.sichert@proxmox.com>
[snip]
prev parent reply other threads:[~2026-04-23 13:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 16:43 [PATCH cluster/docs/manager v2 0/8] add warning messages for high token timeouts in clusters Michael Köppl
2026-04-20 16:43 ` [PATCH docs v2 1/8] asciidoc-pve: allow linking sections with get_help_link Michael Köppl
2026-04-20 16:43 ` [PATCH docs v2 2/8] pvecm: add explicit anchor for token coefficient section Michael Köppl
2026-04-20 16:43 ` [PATCH docs v2 3/8] pvecm: add info about warnings regarding token coefficient Michael Köppl
2026-04-20 16:43 ` [PATCH cluster v2 4/8] add functions to determine warning level for high token timeouts Michael Köppl
2026-04-22 11:40 ` Lukas Sichert
2026-04-22 12:05 ` Michael Köppl
2026-04-22 12:09 ` Michael Köppl
2026-04-20 16:43 ` [PATCH cluster v2 5/8] pvecm: warn users of high token timeouts when using status command Michael Köppl
2026-04-20 16:43 ` [PATCH cluster v2 6/8] api: add token timeout and warning level to cluster join info Michael Köppl
2026-04-21 7:20 ` Friedrich Weber
2026-04-22 12:43 ` Lukas Sichert
2026-04-20 16:43 ` [PATCH manager v2 7/8] ui: cluster info: move initialization of items to initComponent Michael Köppl
2026-04-20 16:43 ` [PATCH manager v2 8/8] ui: cluster info: warn users of high token timeout in join info Michael Köppl
2026-04-22 13:06 ` [PATCH cluster/docs/manager v2 0/8] add warning messages for high token timeouts in clusters Lukas Sichert
2026-04-23 13:59 ` Michael Köppl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DI0L6C6ZSLTV.HEVGMAXJJBI6@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=l.sichert@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.