Re: [PATCH cluster v2 4/8] add functions to determine warning level for high token timeouts

["Michael Köppl" <m.koeppl@proxmox.com>]

On Wed Apr 22, 2026 at 1:40 PM CEST, Lukas Sichert wrote:

[snip]

>> +sub get_timeout_warning {
>> +    my ($total_timeout_secs) = @_;
>> +
>> +    my $level = get_timeout_warning_level($total_timeout_secs);
>> +    return undef if !defined($level);
>> +
>> +    my $level_msg;
>> +    if ($level eq 'change-strongly-recommended') {
>> +        $level_msg = "Changing the token coefficient is strongly recommended";
> In my opinion, "lowering" would be clearer than "changing" here, because this warning is only emitted when the timeout is too high.

Unless @Friedrich or someone else has a strong opinion on this, I'd also
prefer lowering, I think, and I'd adapt v3 accordingly. Thanks for the
suggestion.

>> +    } elsif ($level eq 'change-recommended') {
>> +        $level_msg = "Changing the token coefficient is recommended";
>> +    } elsif ($level eq 'optimize') {
>> +        $level_msg = "Token coefficient can be optimized";
>> +    }
>> +
>> +    return
>> +        "Sum of Corosync token and consensus timeout is ${total_timeout_secs}s. "
>> +        . "$level_msg. "
>> +        . "See https://pve.proxmox.com/pve-docs/chapter-pvecm.html#_changing_the_token_coefficient for details.";
> Maybe it would be better to avoid hardcoding the 'pve.proxmox.com' URL, but to derive the URL from '/etc/hosts' or use '<ip-add>:8006' instead.

I must've missed this when I rebased. Should have been "See 'man pvecm'
for details" already. Will adapt in v3, thanks!

>> +}
>> +
>>  1;
>> -- 
>> 2.47.3