all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Dominik Rusovac" <d.rusovac@proxmox.com>
To: "Fiona Ebner" <f.ebner@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH manager] ui: ha: status: handle 'fencing' for ordering in grid
Date: Tue, 07 Apr 2026 13:04:08 +0200	[thread overview]
Message-ID: <DHMVFPSPZVCC.33PAHD4CBJ6I6@proxmox.com> (raw)
In-Reply-To: <20260407102518.57975-1-f.ebner@proxmox.com>

planned on doing the very same thing

On Tue Apr 7, 2026 at 12:24 PM CEST, Fiona Ebner wrote:
> As reported in the community forum [0], the 'fencing' entry might
> bounce around with each API request (with certain browsers, reproduced
> with Chromium 146.0.7680.164). Handle the type 'fencing' when ordering
> to fix this. Order the entry directly after 'quorum', so it can be
> quickly spotted.

reasonable order, imo

>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  www/manager6/ha/StatusView.js | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/www/manager6/ha/StatusView.js b/www/manager6/ha/StatusView.js
> index 50ad8e84..bc2da71f 100644
> --- a/www/manager6/ha/StatusView.js
> +++ b/www/manager6/ha/StatusView.js
> @@ -8,9 +8,10 @@ Ext.define(
>  
>          sortPriority: {
>              quorum: 1,
> -            master: 2,
> -            lrm: 3,
> -            service: 4,
> +            fencing: 2,
> +            master: 3,
> +            lrm: 4,
> +            service: 5,
>          },
>  
>          initComponent: function () {

lgtm

Reviewed-by: Dominik Rusovac <d.rusovac@proxmox.com>




  reply	other threads:[~2026-04-07 11:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07 10:24 Fiona Ebner
2026-04-07 11:04 ` Dominik Rusovac [this message]
2026-04-07 13:09 ` applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHMVFPSPZVCC.33PAHD4CBJ6I6@proxmox.com \
    --to=d.rusovac@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal