all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH yew-comp] wizard: make content panel resizable too if wizard parent is
@ 2026-04-01 14:34 Christoph Heiss
  2026-04-02  6:27 ` Dominik Csapak
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Heiss @ 2026-04-01 14:34 UTC (permalink / raw)
  To: yew-devel

Without this, the content panel won't be resized together with the
parent wizard dialog, staying static and not filling the dialog content
area.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 src/wizard.rs | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/wizard.rs b/src/wizard.rs
index 7d83da1..6d1d02a 100644
--- a/src/wizard.rs
+++ b/src/wizard.rs
@@ -8,7 +8,7 @@ use html::Scope;
 use indexmap::IndexMap;
 use serde_json::{json, Value};
 
-use pwt::css::{Flex, Overflow};
+use pwt::css::{self, Flex, Overflow};
 use pwt::props::RenderFn;
 use pwt::{prelude::*, AsyncPool};
 
@@ -553,7 +553,10 @@ impl Component for PwtWizard {
             tab_panel.add_item(tab_bar_item, page_content);
         }
 
-        let tab_panel = Mask::new(tab_panel).visible(self.loading);
+        let mut tab_panel = Mask::new(tab_panel).visible(self.loading);
+        if props.resizable {
+            tab_panel.add_class(css::FlexFit);
+        }
 
         Container::new()
             .with_child(
-- 
2.53.0





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH yew-comp] wizard: make content panel resizable too if wizard parent is
  2026-04-01 14:34 [PATCH yew-comp] wizard: make content panel resizable too if wizard parent is Christoph Heiss
@ 2026-04-02  6:27 ` Dominik Csapak
  2026-04-02 10:28   ` Christoph Heiss
  0 siblings, 1 reply; 3+ messages in thread
From: Dominik Csapak @ 2026-04-02  6:27 UTC (permalink / raw)
  To: Christoph Heiss, yew-devel

didn't test it, but is there any argument against always
setting that class?

On 4/1/26 4:33 PM, Christoph Heiss wrote:
> Without this, the content panel won't be resized together with the
> parent wizard dialog, staying static and not filling the dialog content
> area.
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>   src/wizard.rs | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/src/wizard.rs b/src/wizard.rs
> index 7d83da1..6d1d02a 100644
> --- a/src/wizard.rs
> +++ b/src/wizard.rs
> @@ -8,7 +8,7 @@ use html::Scope;
>   use indexmap::IndexMap;
>   use serde_json::{json, Value};
>   
> -use pwt::css::{Flex, Overflow};
> +use pwt::css::{self, Flex, Overflow};
>   use pwt::props::RenderFn;
>   use pwt::{prelude::*, AsyncPool};
>   
> @@ -553,7 +553,10 @@ impl Component for PwtWizard {
>               tab_panel.add_item(tab_bar_item, page_content);
>           }
>   
> -        let tab_panel = Mask::new(tab_panel).visible(self.loading);
> +        let mut tab_panel = Mask::new(tab_panel).visible(self.loading);
> +        if props.resizable {
> +            tab_panel.add_class(css::FlexFit);
> +        }
>   
>           Container::new()
>               .with_child(





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH yew-comp] wizard: make content panel resizable too if wizard parent is
  2026-04-02  6:27 ` Dominik Csapak
@ 2026-04-02 10:28   ` Christoph Heiss
  0 siblings, 0 replies; 3+ messages in thread
From: Christoph Heiss @ 2026-04-02 10:28 UTC (permalink / raw)
  To: Dominik Csapak; +Cc: yew-devel

On Thu Apr 2, 2026 at 8:27 AM CEST, Dominik Csapak wrote:
> didn't test it, but is there any argument against always
> setting that class?

Was a bit reluctant to do that in case there is some weird interaction
somewhere else, as I'm not super deep into yew-{comp/pwt}.

Did a quick test though, at least for only existing wizard (PDM remotes)
it doesn't seem to change anything (kinda expected, I guess).

I'll send a v2 setting it unconditionally, if nothing else speaks
against it.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-02 10:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-01 14:34 [PATCH yew-comp] wizard: make content panel resizable too if wizard parent is Christoph Heiss
2026-04-02  6:27 ` Dominik Csapak
2026-04-02 10:28   ` Christoph Heiss

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal