[PATCH datacenter-manager 1/2] add `make tidy` target

[PATCH datacenter-manager 1/2] add `make tidy` target

[Lukas Wagner]

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 Makefile    | 6 ++++++
 ui/Makefile | 4 ++++
 2 files changed, 10 insertions(+)

diff --git a/Makefile b/Makefile
index 940a2e7c..e1b64e4b 100644
--- a/Makefile
+++ b/Makefile
@@ -160,3 +160,9 @@ dsc-ui: $(UI_DIR)
 
 test:
 	$(CARGO) test $(tests) $(CARGO_BUILD_ARGS)
+
+.PHONY: tidy
+tidy:
+	$(CARGO) fmt
+	$(MAKE) -C $(UI_DIR) tidy
+
diff --git a/ui/Makefile b/ui/Makefile
index 0bab9523..403f6d55 100644
--- a/ui/Makefile
+++ b/ui/Makefile
@@ -128,3 +128,7 @@ clean:
 .PHONY: dinstall
 dinstall: deb
 	dpkg -i $(DEB)
+
+.PHONY: tidy
+tidy:
+	$(CARGO) fmt
-- 
2.47.3

[PATCH datacenter-manager 2/2] add missing .PHONY for the 'test' make target

[Lukas Wagner]

Otherwise, if a 'test' file would exist by accident, the tests would not
be run.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index e1b64e4b..8e1cd139 100644
--- a/Makefile
+++ b/Makefile
@@ -158,6 +158,7 @@ dsc-ui: $(UI_DIR)
 	$(MAKE) -C $(UI_DIR) dsc
 	dcmd mv $(UI_DIR)/proxmox-datacenter-manager-ui*.dsc .
 
+.PHONY: test
 test:
 	$(CARGO) test $(tests) $(CARGO_BUILD_ARGS)
 
-- 
2.47.3

applied: [PATCH datacenter-manager 1/2] add `make tidy` target

[Thomas Lamprecht]

On Wed, 25 Mar 2026 14:44:31 +0100, Lukas Wagner wrote:
> 


Applied, thanks!

Side-note: would using --all for fmt make any difference here? Only checked the
output of `cargo fmt -h` which mentions "Format all packages, and also their
local path-based dependencies", which might be relevant here for the workspace
local lib dependencies?

[1/2] add `make tidy` target
      commit: 58240c95ead3e251770c537d3b96fdb7190ba7d2
[2/2] add missing .PHONY for the 'test' make target
      commit: b5cded6c0b08bde8f5d555f7b1c57ca72ef9df21

Re: applied: [PATCH datacenter-manager 1/2] add `make tidy` target

[Lukas Wagner]

On Wed Mar 25, 2026 at 5:55 PM CET, Thomas Lamprecht wrote:
> Side-note: would using --all for fmt make any difference here? Only checked the
> output of `cargo fmt -h` which mentions "Format all packages, and also their
> local path-based dependencies", which might be relevant here for the workspace
> local lib dependencies?
>

I tried this out before sending the patch. It seems like the `--all`
flag does not make a difference for us, in my experiments a regular
`cargo fmt` would also format all workspace members just fine, so
I left it at that.