Re: [PATCH ha-manager v2 0/4] fix #2751: implement disarm/arm HA for safer cluster maintenance

["Dominik Rusovac" <d.rusovac@proxmox.com>]

Thx for coming up with a v2 so quickly! 

On Sun Mar 22, 2026 at 12:42 AM CET, Thomas Lamprecht wrote:
> The biggest change compared to v1 is how ignore mode handles the service
> status: instead of clearing it entirely, the relevant parts of service
> status are now preserved across the disarm/arm cycle. This allows
> runtime state like maintenance_node to survive, so services correctly
> migrate back to their original node after maintenance ends, even if the
> disarm happened while maintenance was active. Thanks @Dominik R. for
> noticing this.

Alongside repeating the tests conducted for v1, which again were OK, 
I also conducted tests resembling test-disarm-maintenance{1,2,3}
in a real cluster, which were also OK.

>
> To keep the preserved state clean, stale runtime data (failed_nodes,
> cmd, target, ...) is pruned from service entries on disarm - both in
> freeze and ignore mode - so the state machine starts fresh on re-arm.
> The status API overrides the displayed service state to 'ignore' during
> disarm-ignore mode, while the internal state stays untouched for
> seamless resume.
>
> On arm-ha from ignore mode, the CRM now rechecks the previous resource's
> node against the resource service config, picking up any manual
> migrations the admin performed while HA tracking was suspended.
>
> First patch 1/4 is new and adds a manual-migrate simulator command as a
> preparatory patch, since it is independently useful for testing the
> per-service 'ignored' state handling.
>
> Previous discussion and v1:
> https://lore.proxmox.com/pve-devel/20260309220128.973793-1-t.lamprecht@proxmox.com/
>

[snip]

lgtm, consider this series.

Reviewed-by: Dominik Rusovac <d.rusovac@proxmox.com>
Tested-by: Dominik Rusovac <d.rusovac@proxmox.com>