all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Arthur Bied-Charreton" <a.bied-charreton@proxmox.com>,
	<pve-devel@lists.proxmox.com>
Subject: Re: [PATCH proxmox-widget-toolkit 1/2] utils: Add OAuth2 flow handlers
Date: Mon, 23 Mar 2026 13:26:23 +0100	[thread overview]
Message-ID: <DHA5SIJ2OLNK.3UIP2UJ7L97EH@proxmox.com> (raw)
In-Reply-To: <20260213160415.609868-10-a.bied-charreton@proxmox.com>

Seems like formatting is off in this and the next patch - make sure to
run `make tidy` for your JS changes. :)

On Fri Feb 13, 2026 at 5:04 PM CET, Arthur Bied-Charreton wrote:
> Introduce the Proxmox.OAuth2 singleton supporting Google and Microsoft
> OAuth2. The flow is handled by opening a new window with the
> authorization URL, and expects to receive the resulting authorization
> code from the redirect handler via a [BroadcastChannel].
>
> [BroadcastChannel]
> https://developer.mozilla.org/en-US/docs/Web/API/BroadcastChannel
>
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> ---
>  src/Utils.js | 88 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 88 insertions(+)
>
> diff --git a/src/Utils.js b/src/Utils.js
> index 5457ffa..5cbe9b6 100644
> --- a/src/Utils.js
> +++ b/src/Utils.js
> @@ -1723,6 +1723,94 @@ Ext.define('Proxmox.Utils', {
>      },
>  });
>  
> +Ext.define('Proxmox.OAuth2', {
> +    singleton: true,
> +
> +    handleGoogleFlow: function (clientId, clientSecret) {
> +        return this._handleFlow({
> +            clientId,
> +            clientSecret,
> +            authUrl: 'https://accounts.google.com/o/oauth2/v2/auth',
> +            tokenUrl: 'https://oauth2.googleapis.com/token',
> +            scope: 'https://mail.google.com',
> +            extraAuthParams: {
> +                access_type: 'offline',
> +                prompt: 'consent',
> +            },
> +        });
> +    },
> +
> +    handleMicrosoftFlow: function(clientId, clientSecret, tenantId) {
> +        return this._handleFlow({
> +            clientId,
> +            clientSecret,
> +            authUrl: `https://login.microsoftonline.com/${tenantId}/oauth2/v2.0/authorize`,
> +            tokenUrl: `https://login.microsoftonline.com/${tenantId}/oauth2/v2.0/token`,
> +            scope: 'https://outlook.office.com/SMTP.Send offline_access',
> +            extraAuthParams: {
> +                prompt: 'consent',
> +            },
> +        });
> +    },
> +
> +    _handleFlow: function (config) {
> +        return new Promise((resolve, reject) => {
> +            let redirectUri = window.location.origin;
> +            let channelName = `oauth2_${crypto.randomUUID()}`;
> +            let state = encodeURIComponent(JSON.stringify({ channelName }));
> +
> +            let authParams = new URLSearchParams({
> +                client_id: config.clientId,
> +                response_type: 'code',
> +                redirect_uri: redirectUri,
> +                scope: config.scope,
> +                state,
> +                ...config.extraAuthParams,
> +            });
> +
> +            let authUrl = `${config.authUrl}?${authParams}`;
> +
> +            // Opens OAuth2 authentication window. The app's redirect handler must
> +            // extract the authorization code from the callback URL and send it via:
> +            // new BroadcastChannel(state.channelName).postMessage({ code })
> +            let channel = new BroadcastChannel(channelName);
> +            let popup = window.open(authUrl);
> +            if (!popup) {
> +                reject(new Error('Could not open authentication window'));
> +                return;
> +            }
> +
> +            channel.addEventListener('message', async (event) => {
> +                if (popup && !popup.closed) {
> +                    popup.close();
> +                }
> +                channel.close();
> +
> +                try {
> +                    let response = await fetch(config.tokenUrl, {
> +                        method: 'POST',
> +                        headers: {
> +                            'Content-Type': 'application/x-www-form-urlencoded',
> +                        },
> +                        body: new URLSearchParams({
> +                            grant_type: 'authorization_code',
> +                            code: event.data.code,
> +                            client_id: config.clientId,
> +                            client_secret: config.clientSecret,
> +                            redirect_uri: redirectUri,
> +                        }),
> +                    });
> +
> +                    let tokens = await response.json();
> +                    resolve(tokens.refresh_token);
> +                } catch (error) {
> +                    reject(error);
> +                }
> +            });
> +        })
> +    }
> +})
> +
>  Ext.define('Proxmox.Async', {
>      singleton: true,
>  





  reply	other threads:[~2026-03-23 12:27 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13 16:03 [PATCH cluster/docs/manager/proxmox{,-perl-rs,-widget-toolkit} 00/17] fix #7238: Add XOAUTH2 authentication support for SMTP notification targets Arthur Bied-Charreton
2026-02-13 16:03 ` [PATCH proxmox 1/7] notify (smtp): Introduce xoauth2 module Arthur Bied-Charreton
2026-02-13 16:04 ` [PATCH proxmox 2/7] notify (smtp): Introduce state module Arthur Bied-Charreton
2026-03-23 12:26   ` Lukas Wagner
2026-03-23 16:32     ` Arthur Bied-Charreton
2026-03-24  8:50     ` Arthur Bied-Charreton
2026-02-13 16:04 ` [PATCH proxmox 3/7] notify (smtp): Factor out transport building logic into own function Arthur Bied-Charreton
2026-02-13 16:04 ` [PATCH proxmox 4/7] notify (smtp): Update API with OAuth2 parameters Arthur Bied-Charreton
2026-02-13 16:04 ` [PATCH proxmox 5/7] notify (smtp): Add state handling logic Arthur Bied-Charreton
2026-03-23 12:26   ` Lukas Wagner
2026-02-13 16:04 ` [PATCH proxmox 6/7] notify (smtp): Add XOAUTH2 authentication support Arthur Bied-Charreton
2026-03-23 12:26   ` Lukas Wagner
2026-02-13 16:04 ` [PATCH proxmox 7/7] notify (smtp): Add logging and state-related error types Arthur Bied-Charreton
2026-03-23 12:26   ` Lukas Wagner
2026-02-13 16:04 ` [PATCH proxmox-perl-rs 1/1] notify (smtp): add oauth2 parameters to bindings Arthur Bied-Charreton
2026-03-23 12:26   ` Lukas Wagner
2026-03-23 16:44     ` Arthur Bied-Charreton
2026-02-13 16:04 ` [PATCH proxmox-widget-toolkit 1/2] utils: Add OAuth2 flow handlers Arthur Bied-Charreton
2026-03-23 12:26   ` Lukas Wagner [this message]
2026-02-13 16:04 ` [PATCH proxmox-widget-toolkit 2/2] notifications: Add opt-in OAuth2 support for SMTP targets Arthur Bied-Charreton
2026-03-23 12:26   ` Lukas Wagner
2026-03-23 16:49     ` Arthur Bied-Charreton
2026-02-13 16:04 ` [PATCH pve-manager 1/5] notifications: Add OAuth2 parameters to schema and add/update endpoints Arthur Bied-Charreton
2026-03-23 12:26   ` Lukas Wagner
2026-02-13 16:04 ` [PATCH pve-manager 2/5] notifications: Add trigger-state-refresh endpoint Arthur Bied-Charreton
2026-03-23 12:26   ` Lukas Wagner
2026-02-13 16:04 ` [PATCH pve-manager 3/5] notifications: Trigger notification target refresh in pveupdate Arthur Bied-Charreton
2026-02-13 16:04 ` [PATCH pve-manager 4/5] notifications: Handle OAuth2 callback in login handler Arthur Bied-Charreton
2026-02-13 16:04 ` [PATCH pve-manager 5/5] notifications: Opt into OAuth2 authentication Arthur Bied-Charreton
2026-02-13 16:04 ` [PATCH pve-cluster 1/1] notifications: Add refresh_targets subroutine to PVE::Notify Arthur Bied-Charreton
2026-03-23 12:26   ` Lukas Wagner
2026-03-23 16:54     ` Arthur Bied-Charreton
2026-02-13 16:04 ` [PATCH pve-docs 1/1] notifications: Add section about OAuth2 to SMTP targets docs Arthur Bied-Charreton
2026-03-23 12:25 ` [PATCH cluster/docs/manager/proxmox{,-perl-rs,-widget-toolkit} 00/17] fix #7238: Add XOAUTH2 authentication support for SMTP notification targets Lukas Wagner
2026-03-25 13:16 ` superseded: " Arthur Bied-Charreton
  -- strict thread matches above, loose matches on Subject: below --
2026-02-04 16:13 [RFC cluster/docs/manager/proxmox{,-perl-rs,-widget-toolkit} 00/15] " Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH proxmox-widget-toolkit 1/2] utils: Add OAuth2 flow handlers Arthur Bied-Charreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHA5SIJ2OLNK.3UIP2UJ7L97EH@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=a.bied-charreton@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal