Re: [PATCH proxmox-backup v1 1/2] fix #7400: api: gracefully handle corrupted job statefiles

["Michael Köppl" <m.koeppl@proxmox.com>]

On Wed Mar 18, 2026 at 5:15 PM CET, Christian Ebner wrote:
> On 3/17/26 5:07 PM, Michael Köppl wrote:
>> Previously, if a job statefile was empty or corrupted (e.g. due to an
>> I/O error or an abrupt shutdown), the JobStatus::load method would
>> return an error that would be propagated up, causing the endpoint to
>> return an error to the user, meaning users would not see any of their
>> jobs if a single job had a corrupted statefile.
>> 
>> Instead, handle the error explicitly, logging a warning and returning a
>> default JobScheduleStatus, such that jobs lists can still be fetched,
>> displaying the affected job as configured but simply missing its last
>> run status.
>> 
>> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
>> ---
>
> Thanks for the patches, one comment for this patch.
>
> Instead of adapting all the call sides, loading of the state file might 
> be moved to compute_schedule_status() in a preparatory patch, passing 
> the job type and id as parameters. The improved error handling can then 
> be done inside that helper.

Thanks for having a look! Yeah, true. Was so busy trying to avoid moving
too much stuff around that I didn't see the cleaner solution. Will send
an updated v2, thanks for the feedback.