Re: applied: [PATCH ha-manager 0/2] fix #7399: check if required rule props are set

["Daniel Kral" <d.kral@proxmox.com>]

On Wed Mar 11, 2026 at 6:06 PM CET, Thomas Lamprecht wrote:
> On Wed, 11 Mar 2026 13:49:34 +0100, Daniel Kral wrote:
>> The API endpoints allow users to set empty 'nodes' and 'resources'
>> properties for HA rules, which are not handled by the api schema
>> verification nor the api handlers themselves.
>> 
>> PATCH 1 fixes the
>> 
>>     got unexpected error - cannot lookup undefined type! at
>>     /usr/share/perl5/PVE/HA/Config.pm line 232.
>> 
>> [...]
>
> Applied, thanks.
>
> Tiny nit: A short hint in 1/2 that not guarding the result of
> $class->lookup($rule->{type}) anymore is fine, as lookup dies
> anyway if the plugin cannot be found would have been nice here,
> but just a detail.

Good point, the helper does rely on the fact that we don't allow unknown
section types in the rules config and therefore $rule and $rule->{type}
not being set, but still existent in $rules->{ids}.

I'll keep that in mind in the future and address this in a patch series
which should reduce the amount of die's in the Manager.pm to only the
debug assertions!

>
> [1/2] rules: ensure rule is defined and has type in set_rule_defaults
>       commit: 00a71f147a203d15e952ca016c188e3e8a0cb518
> [2/2] api: rules: check for non-empty nodes and resources properties
>       commit: 41603823b12cdc10bb6041b002544795ddd0f91b