all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Maximiliano Sandoval" <m.sandoval@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH docs v2 0/2]  local-zfs: rephrase ARC limit
Date: Wed, 11 Mar 2026 14:36:41 +0100	[thread overview]
Message-ID: <DGZZRT9PW12D.2CREHU72HT3QQ@proxmox.com> (raw)
In-Reply-To: <20260226084639.107816-1-m.sandoval@proxmox.com>

On Thu Feb 26, 2026 at 9:46 AM CET, Maximiliano Sandoval wrote:
> See the first commit for more information.
>
> Regarding adding the manual page: It is not very obvious where to find the
> documentation for the value (I was personally interested in the units for
> zfs_arc_max). Only after a `man -Kw zfs_arc_max` I found zfs(4) (as its sole
> output).
>
> I also considered just saying that we only fallback to ZFS' defaults without
> specifying the exact values, perhaps only that they quite high compared to 10%.
>
> Differences from v1:
>  - Document that we used ZFS' defaults before 8.1
>  - Use lowercase in commit message
>
> Maximiliano Sandoval (2):
>   local-zfs: rephrase ARC limit
>   local-zfs: add reference to the zfs(4) manual
>
>  local-zfs.adoc | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)

other than the small nit i left on the first commit, this looks alright
to me, consider this:

Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>




      parent reply	other threads:[~2026-03-11 13:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26  8:46 Maximiliano Sandoval
2026-02-26  8:46 ` [PATCH docs v2 1/2] " Maximiliano Sandoval
2026-03-11 13:35   ` Shannon Sterz
2026-03-12 13:48   ` Friedrich Weber
2026-02-26  8:46 ` [PATCH docs v2 2/2] local-zfs: add reference to the zfs(4) manual Maximiliano Sandoval
2026-03-11 13:36 ` Shannon Sterz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGZZRT9PW12D.2CREHU72HT3QQ@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal