From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>
Cc: yew-devel@lists.proxmox.com
Subject: Re: [PATCH yew-comp 00/15] clippy clean up proxmox-yew-comp
Date: Mon, 09 Mar 2026 14:13:00 +0100 [thread overview]
Message-ID: <DGYA0KWDXGOP.9D7A6E013JOF@proxmox.com> (raw)
In-Reply-To: <591b094a-7451-48ec-9683-d679d46b1705@proxmox.com>
On Mon Mar 9, 2026 at 1:54 PM CET, Dominik Csapak wrote:
> most of them look fine to me IMO,
> but I'm thinking maybe we should have (for the gui at least?) a custom
> clippy config that removes some default lints, e.g. the
> large_enum_variant and too_many_arguments lint
> don' gain us much most of the time
>
> (Msg enums are only sent every once in a while,
> so performance impact is negligible here;
> long argument lists only get ignored most of the time anyway)
>
> also the commit:
> fix various minor clippy lints has some in the list
> that are not actually part of the commit?
> (like again the 'too_many_arguments' one)
ah sorry something must have slipped into that list, i'll go over it
again.
> so before i go and apply this (at least partially)
> we might want to look over the lints again to see
> which one we can/should ignore here?
that's fair i also don't think we gain much with the examples you
mentioned. we could add a `lints` section to our cargo toml, something
like this to start with possibly:
```toml
[lints.clippy]
too_many_arguments = "allow"
enum_variant_names = "allow"
large_enum_variant = "allow"
```
what do you think?
-->8 snip 8<--
next prev parent reply other threads:[~2026-03-09 13:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 11:21 Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 01/15] tree wide: fix clippy lint "useless_conversion" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 02/15] tree wide: fix clippy lint "new_without_default" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 03/15] tree wide: fix clippy lint "redundant_static_lifetimes" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 04/15] tree wide: fix clippy lint "unnecessary_lazy_evaluations" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 05/15] tree wide: fix clippy lint "unwrap_or_default" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 06/15] tree wide: fix clippy lint "clone_on_copy" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 07/15] tree wide: fix clippy lint "collapsible_else_if" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 08/15] tree wide: fix various minor clippy lints Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 09/15] tree wide: fix clippy lint "manual_strip" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 10/15] lxc_property/qemu_property: fix clippy lint "match_like_matches_macro" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 11/15] firewall_property: fix clippy lint "redundant_guards" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 12/15] qemu_property: fix clippy lint "redundant_pattern_matching" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 13/15] qemu_hardware_pane/lxc_resources_panel: allow clippy::enum_variant_names Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 14/15] tree wide: fix clippy lint "large_enum_variant" Shannon Sterz
2026-03-06 11:21 ` [PATCH yew-comp 15/15] tree wide: allow clippy "too_many_arguments" warning selectively Shannon Sterz
2026-03-09 12:54 ` [PATCH yew-comp 00/15] clippy clean up proxmox-yew-comp Dominik Csapak
2026-03-09 13:13 ` Shannon Sterz [this message]
2026-03-09 13:15 ` Dominik Csapak
2026-03-09 15:30 ` Superseded: " Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGYA0KWDXGOP.9D7A6E013JOF@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.