From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Maximiliano Sandoval" <m.sandoval@proxmox.com>,
<pve-devel@lists.proxmox.com>
Subject: Re: [PATCH ha-manager v2] resources: Expand max_restart option
Date: Tue, 03 Mar 2026 17:46:47 +0100 [thread overview]
Message-ID: <DGTASZXER9BD.QP7E4OBU8RB1@proxmox.com> (raw)
In-Reply-To: <20260303132206.222398-1-m.sandoval@proxmox.com>
I prefer this one over v1 because I think it's more comprehensible. lgtm
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
On Tue Mar 3, 2026 at 2:22 PM CET, Maximiliano Sandoval wrote:
> When read next to `max_relocate` it is not clear which happens first
> after a service fails to start.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>
> ---
>
> Differences from v1:
> - Incorporate feedback. Namely, "the service will be attempted to be relocated"
> was a bit too convoluted.
>
> src/PVE/HA/Resources.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm
> index 68d9d16..404f6dc 100644
> --- a/src/PVE/HA/Resources.pm
> +++ b/src/PVE/HA/Resources.pm
> @@ -73,7 +73,8 @@ EODESC
> },
> max_restart => {
> description => "Maximal number of tries to restart the service on"
> - . " a node after its start failed.",
> + . " a node after its start failed. When reached, the HA manager will try to"
> + . " relocate the service to an eligible node.",
> type => 'integer',
> optional => 1,
> default => 1,
next prev parent reply other threads:[~2026-03-03 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 13:22 Maximiliano Sandoval
2026-03-03 16:46 ` Michael Köppl [this message]
2026-03-03 20:09 ` Thomas Lamprecht
2026-03-04 7:58 ` Daniel Kral
2026-03-04 8:36 ` superseded: " Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGTASZXER9BD.QP7E4OBU8RB1@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.