all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Dominik Rusovac" <d.rusovac@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: applied: [PATCH datacenter-manager] ui: fix clippy warnings
Date: Tue, 03 Mar 2026 10:49:48 +0100	[thread overview]
Message-ID: <DGT1XQER46RF.D6OKEL024UYJ@proxmox.com> (raw)
In-Reply-To: <20260303075523.86754-1-d.rusovac@proxmox.com>

On Tue Mar 3, 2026 at 8:55 AM CET, Dominik Rusovac wrote:
> Remove redundant guard and needless borrow.
>
> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
> ---
>  ui/src/tasks.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/src/tasks.rs b/ui/src/tasks.rs
> index 0f9a9aa..4f77fd3 100644
> --- a/ui/src/tasks.rs
> +++ b/ui/src/tasks.rs
> @@ -118,7 +118,7 @@ pub fn format_optional_remote_upid(upid: &str, include_remote: bool) -> String {
>              Ok(NativeUpid::PbsUpid(upid)) => {
>                  format_task_description(&upid.worker_type, upid.worker_id.as_deref())
>              }
> -            Err(_) => format_upid(&remote_upid.upid()),
> +            Err(_) => format_upid(remote_upid.upid()),
>          };
>  
>          if include_remote {
> @@ -155,7 +155,7 @@ impl TaskWorkerType {
>              task_type if task_type.starts_with("vz") && task_type != "vzdump" => {
>                  TaskWorkerType::Lxc
>              }
> -            task_type if task_type == "vzdump" => TaskWorkerType::Backup,
> +            "vzdump" => TaskWorkerType::Backup,
>              task_type if task_type.starts_with("ceph") => TaskWorkerType::Ceph,
>              task_type if task_type.starts_with("ha") => TaskWorkerType::Ha,
>              other => TaskWorkerType::Other(other.to_string()),

applied, thanks!




  parent reply	other threads:[~2026-03-03  9:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03  7:55 Dominik Rusovac
2026-03-03  9:32 ` Dominik Rusovac
2026-03-03  9:49 ` Lukas Wagner [this message]
2026-03-03  9:31 Dominik Rusovac
2026-03-03  9:49 ` applied: " Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGT1XQER46RF.D6OKEL024UYJ@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=d.rusovac@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal