* [PATCH datacenter-manager] ui: fix clippy warnings
@ 2026-03-03 9:31 Dominik Rusovac
2026-03-03 9:49 ` applied: " Lukas Wagner
0 siblings, 1 reply; 3+ messages in thread
From: Dominik Rusovac @ 2026-03-03 9:31 UTC (permalink / raw)
To: pdm-devel
Remove redundant guard and needless borrow.
Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
---
ui/src/tasks.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/src/tasks.rs b/ui/src/tasks.rs
index 0f9a9aa..4f77fd3 100644
--- a/ui/src/tasks.rs
+++ b/ui/src/tasks.rs
@@ -118,7 +118,7 @@ pub fn format_optional_remote_upid(upid: &str, include_remote: bool) -> String {
Ok(NativeUpid::PbsUpid(upid)) => {
format_task_description(&upid.worker_type, upid.worker_id.as_deref())
}
- Err(_) => format_upid(&remote_upid.upid()),
+ Err(_) => format_upid(remote_upid.upid()),
};
if include_remote {
@@ -155,7 +155,7 @@ impl TaskWorkerType {
task_type if task_type.starts_with("vz") && task_type != "vzdump" => {
TaskWorkerType::Lxc
}
- task_type if task_type == "vzdump" => TaskWorkerType::Backup,
+ "vzdump" => TaskWorkerType::Backup,
task_type if task_type.starts_with("ceph") => TaskWorkerType::Ceph,
task_type if task_type.starts_with("ha") => TaskWorkerType::Ha,
other => TaskWorkerType::Other(other.to_string()),
--
2.47.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* applied: [PATCH datacenter-manager] ui: fix clippy warnings
2026-03-03 9:31 [PATCH datacenter-manager] ui: fix clippy warnings Dominik Rusovac
@ 2026-03-03 9:49 ` Lukas Wagner
0 siblings, 0 replies; 3+ messages in thread
From: Lukas Wagner @ 2026-03-03 9:49 UTC (permalink / raw)
To: Dominik Rusovac, pdm-devel
On Tue Mar 3, 2026 at 10:31 AM CET, Dominik Rusovac wrote:
> Remove redundant guard and needless borrow.
>
> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
> ---
> ui/src/tasks.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/src/tasks.rs b/ui/src/tasks.rs
> index 0f9a9aa..4f77fd3 100644
> --- a/ui/src/tasks.rs
> +++ b/ui/src/tasks.rs
> @@ -118,7 +118,7 @@ pub fn format_optional_remote_upid(upid: &str, include_remote: bool) -> String {
> Ok(NativeUpid::PbsUpid(upid)) => {
> format_task_description(&upid.worker_type, upid.worker_id.as_deref())
> }
> - Err(_) => format_upid(&remote_upid.upid()),
> + Err(_) => format_upid(remote_upid.upid()),
> };
>
> if include_remote {
> @@ -155,7 +155,7 @@ impl TaskWorkerType {
> task_type if task_type.starts_with("vz") && task_type != "vzdump" => {
> TaskWorkerType::Lxc
> }
> - task_type if task_type == "vzdump" => TaskWorkerType::Backup,
> + "vzdump" => TaskWorkerType::Backup,
> task_type if task_type.starts_with("ceph") => TaskWorkerType::Ceph,
> task_type if task_type.starts_with("ha") => TaskWorkerType::Ha,
> other => TaskWorkerType::Other(other.to_string()),
applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* applied: [PATCH datacenter-manager] ui: fix clippy warnings
2026-03-03 7:55 Dominik Rusovac
@ 2026-03-03 9:49 ` Lukas Wagner
0 siblings, 0 replies; 3+ messages in thread
From: Lukas Wagner @ 2026-03-03 9:49 UTC (permalink / raw)
To: Dominik Rusovac, pve-devel
On Tue Mar 3, 2026 at 8:55 AM CET, Dominik Rusovac wrote:
> Remove redundant guard and needless borrow.
>
> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
> ---
> ui/src/tasks.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/src/tasks.rs b/ui/src/tasks.rs
> index 0f9a9aa..4f77fd3 100644
> --- a/ui/src/tasks.rs
> +++ b/ui/src/tasks.rs
> @@ -118,7 +118,7 @@ pub fn format_optional_remote_upid(upid: &str, include_remote: bool) -> String {
> Ok(NativeUpid::PbsUpid(upid)) => {
> format_task_description(&upid.worker_type, upid.worker_id.as_deref())
> }
> - Err(_) => format_upid(&remote_upid.upid()),
> + Err(_) => format_upid(remote_upid.upid()),
> };
>
> if include_remote {
> @@ -155,7 +155,7 @@ impl TaskWorkerType {
> task_type if task_type.starts_with("vz") && task_type != "vzdump" => {
> TaskWorkerType::Lxc
> }
> - task_type if task_type == "vzdump" => TaskWorkerType::Backup,
> + "vzdump" => TaskWorkerType::Backup,
> task_type if task_type.starts_with("ceph") => TaskWorkerType::Ceph,
> task_type if task_type.starts_with("ha") => TaskWorkerType::Ha,
> other => TaskWorkerType::Other(other.to_string()),
applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-03 9:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-03 9:31 [PATCH datacenter-manager] ui: fix clippy warnings Dominik Rusovac
2026-03-03 9:49 ` applied: " Lukas Wagner
-- strict thread matches above, loose matches on Subject: below --
2026-03-03 7:55 Dominik Rusovac
2026-03-03 9:49 ` applied: " Lukas Wagner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.