Re: [PATCH datacenter-manager v2 0/2] improvements for ParallelFetcher

["Lukas Wagner" <l.wagner@proxmox.com>]

Hi Lukas,

thanks for testing/reviewing these changes. I'll post a v3 with some
additional (minor) improvements and will include your R-b/T-b tags
there.

On Tue Feb 24, 2026 at 2:42 PM CET, Lukas Sichert wrote:
> The changes were reviewed and tested in a cluster consisting of two
> PVE nodes and one PBS. The following features were considered for testing:
>
> Update handling:
> The update summary could be retrieved without issues.
>
> Tasks:
> The task log was displayed correctly.
>
> Only for the cluster:
> SDN:
> A Simple Zone and an EVPN Zone were created.
> Both zones and the EVPN Controller were displayed correctly.
>
> Firewall:
> Node firewall rules and datacenter firewall configuration were shown
> correctly.
>
> The tests were also repeated with one of the nodes offline, and
> everything still worked as expected.
>
> While reviewing the code, I noticed that the async fetchers currently
> have no explicit timeouts. If one of the fetch operations blocks
> indefinitely, it could stall the overall execution. Adding this in a
> future commit would improve robustness.

Very nice catch! I'll consider this for a future followup - although I'm
not yet sure where the best place for adding a timeout mechanism would
be, either right inside the parallel fetcher code, the individual
handler fn's in the call sites, or directly in the PVE API bindings.

>
> Reviewed-by: Lukas Sichert <l.sichert@proxmox.com>
> Tested-by: Lukas Sichert <l.sichert@proxmox.com>
>