Re: [PATCH widget-toolkit] fix regression in checkcolumn rendering

["Michael Köppl" <m.koeppl@proxmox.com>]

Gave this a quick spin since I was just encountering the missing
checkboxes. Checked the various places we're using checkcolumn and seems
to work as advertised.

Tested-by: Michael Köppl <m.koeppl@proxmox.com>

On Tue Feb 24, 2026 at 9:55 AM CET, Dominik Csapak wrote:
> in commit 57cd471f79ecd6b98c9cadb600ba0255360980fe the default column
> renderer was changed to Ext.htmlEncode, so that by default, we don't
> return raw HTML there anymore.
>
> The 'checkcolumn' relies on that behavior though, so we have to reset
> the renderer there to 'undefined' for it to work properly.
>
> This fixes all uses of 'checkcolumn', for example the enabled column in
> the boot order edit window for virtual machines.
>
> Fixes: 57cd471 (prevent interpreting of HTML in column grids by default)
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/Toolkit.js | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/src/Toolkit.js b/src/Toolkit.js
> index d4e579b..bdfadf8 100644
> --- a/src/Toolkit.js
> +++ b/src/Toolkit.js
> @@ -769,12 +769,21 @@ Ext.define('Proxmox.Cookies', {
>  
>  // Prevents html entities to be interpreted by the browser in grid columns by
>  // default. Custom renderer have to take care of this by themselves.
> +//
> +// Reset the renderer for the 'checkcolumn' back to undefined, since it relies
> +// on the renderer returning raw HTML.
>  Ext.define('Proxmox.grid.column.Column', {
>      override: 'Ext.grid.column.Column',
>  
>      renderer: Ext.htmlEncode,
>  });
>  
> +Ext.define('Proxmox.grid.column.Check', {
> +    override: 'Ext.grid.column.Column',
> +
> +    renderer: undefined,
> +});
> +
>  // force alert boxes to be rendered with an Error Icon
>  // since Ext.Msg is an object and not a prototype, we need to override it
>  // after the framework has been initiated