all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Shan Shaji" <s.shaji@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: applied: [PATCH datacenter-manager 0/2] fix: cli: bash completions not working for CLI tools
Date: Mon, 23 Feb 2026 15:26:14 +0100	[thread overview]
Message-ID: <DGMET14XKBGK.3HS6NBJYVJEPP@proxmox.com> (raw)
In-Reply-To: <20260206163519.218579-1-s.shaji@proxmox.com>

On Fri Feb 6, 2026 at 5:35 PM CET, Shan Shaji wrote:
> Shell completions for the CLIs were not working because the completion
> files were installed with the `.bc` extension.
>
> According to the bash-completion documentation [1], completion files should
> either use the `.bash` extension or no extension at all. Debian currently ships
> bash-completion 2.16 [2]. Since installing files without an extension is
> planned to be deprecated in >=2.18, use the `.bash` extension for
> compatibility with future versions.
>
> documentaion quote:
>> The completion filename for command foo in this directory should be foo.bash.
>> Unsuffixed foo also works, but it is deprecated in >= 2.18.
>
> Passing the `bashcomplete` argument to proxmox-datacenter-api and
> proxmox-datacenter-privileged-api results in an error instead of generating
> completions. Since these binaries are systemd-managed service executables
> rather than user facing CLI tools, providing bash completion helpers might not
> be useful. Since i was not sure why we had completions for the same
> i added it as another patch. Please correct me if i have missed anything. 
>
> [1]- https://github.com/scop/bash-completion/blob/06547b33f6de3b6f8ba730f00e7f585297a31b4f/README.md?plain=1#L184
> [2]- https://packages.debian.org/en/trixie/bash-completion
>

applied, thank you!

I squashed in a tiny change into the first commit - the `make clean` rule
still cleaned the old .bc files, so I changed that to remove .bash
files.




  parent reply	other threads:[~2026-02-23 14:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-06 16:35 Shan Shaji
2026-02-06 16:35 ` [PATCH datacenter-manager 1/2] fix: cli: replace completion file suffix from `.bc` to `.bash` Shan Shaji
2026-02-06 16:35 ` [PATCH datacenter-manager 2/2] fix: cli: remove completion files for service bins Shan Shaji
2026-02-23 14:26 ` Lukas Wagner [this message]
2026-02-24  8:40   ` applied: [PATCH datacenter-manager 0/2] fix: cli: bash completions not working for CLI tools Shan Shaji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGMET14XKBGK.3HS6NBJYVJEPP@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    --cc=s.shaji@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal