Re: [pdm-devel] [PATCH datacenter-manager 0/7] fix #7192: properly enumerate PBS realms in 'Add Remote' wizard

["Shan Shaji" <s.shaji@proxmox.com>]

I have gone through the code and overall, i believe the code looks
good as well. but a second review might also be nice.

Reviewed-by: Shan Shaji <s.shaji@proxmox.com>

On Fri Feb 20, 2026 at 4:17 PM CET, Shan Shaji wrote:
>
> Applied this series and tested the changes.
>
> ```
>  Error: api error (status = 400: client error (Connect))
> ```
>
> The above error doesn't appear anymore in the settings tab. I was able to
> choose between the realms and add a backup server using `pbs` realm.
>
> Tested-by: Shan Shaji <s.shaji@proxmox.com>
>
>
> On Mon Dec 29, 2025 at 2:44 PM CET, Lukas Wagner wrote:
>> This fixes #7192 [1] by adding the needed API functions to enumerate
>> remotes from PBS remotes. The the realm selector component is changed
>> to support a realm-type property, based on which it selects the URL
>> from which it requests the realms.
>>
>> This series also contains some minor renames in the UI code, as
>> the old name `PveRealmSelector` did not make sense any more.
>>
>> [1]: https://bugzilla.proxmox.com/show_bug.cgi?id=7192
>>
>>
>> proxmox-datacenter-manager:
>>
>> Lukas Wagner (7):
>>   pbs-client: add `list_domains`
>>   api: pbs: add /pbs/realms endpoint
>>   ui: rename pve_realm_selector module to remote_realm_selector
>>   ui: widgets: rename PveRealmSelector to RemoteRealmSelector
>>   ui: widgets: make RemoteRealmSelectorComp private
>>   ui: widget: remote realm selector: add missing docstrings
>>   ui: widgets: remote realm selector: support PBS remotes
>>
>>  server/src/api/pbs/mod.rs                     | 55 +++++++++++++++++++
>>  server/src/pbs_client.rs                      |  8 ++-
>>  ui/src/remotes/wizard_page_info.rs            |  4 +-
>>  ui/src/widget/mod.rs                          |  4 +-
>>  ...m_selector.rs => remote_realm_selector.rs} | 25 ++++++---
>>  5 files changed, 84 insertions(+), 12 deletions(-)
>>  rename ui/src/widget/{pve_realm_selector.rs => remote_realm_selector.rs} (84%)
>>
>>
>> Summary over all repositories:
>>   5 files changed, 84 insertions(+), 12 deletions(-)