From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Shan Shaji" <s.shaji@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager/proxmox v3 0/7] fix #6914: add option to remove already existing token
Date: Fri, 13 Feb 2026 14:19:23 +0100 [thread overview]
Message-ID: <DGDV4EJF1TUW.1C5DBYMMLW8SD@proxmox.com> (raw)
In-Reply-To: <20260211152016.445817-1-s.shaji@proxmox.com>
On Wed Feb 11, 2026 at 4:20 PM CET, Shan Shaji wrote:
> **note**: Sending v3 because the generated code for the delete_token
> method in pve-api-types has changed. I rebased the series onto master and
> re-tested the changes.
>
> If a user removed a remote without deleting its associated token,
> PDM would not allow re-adding the same remote unless the token
> was changed. To fix this, support for optionally deleting the token
> from the remote has been added.
>
> This patch series adds support to delete the token using an optional
> boolean flag in CLIs ie. on both admin and client. Additionaly, added a
> check box inside the UI that allow users to choose whether to
> delete the token while removing the remote.
>
Seems to work fine, test both, PVE and PBS remotes. Can confirm the
removing the token works as expected.
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
Left some comments with the individual patches for improvements for v4.
prev parent reply other threads:[~2026-02-13 13:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 15:20 Shan Shaji
2026-02-11 15:20 ` [PATCH datacenter-manager v3 1/6] server: pbs-client: add delete admin token method Shan Shaji
2026-02-13 13:20 ` Lukas Wagner
2026-02-11 15:20 ` [PATCH datacenter-manager v3 2/6] server: api: add support to optionally delete token from remote Shan Shaji
2026-02-13 13:20 ` Lukas Wagner
2026-02-18 8:38 ` Maximiliano Sandoval
2026-02-11 15:20 ` [PATCH datacenter-manager v3 3/6] pdm-client: accept `delete-token` argument for deleting api token Shan Shaji
2026-02-13 13:20 ` Lukas Wagner
2026-02-11 15:20 ` [PATCH datacenter-manager v3 4/6] cli: client: add `delete-token` option to delete token from remote Shan Shaji
2026-02-13 13:21 ` Lukas Wagner
2026-02-11 15:20 ` [PATCH datacenter-manager v3 5/6] fix: ui: add remove confirmation dialog with optional token deletion Shan Shaji
2026-02-13 13:21 ` Lukas Wagner
2026-02-11 15:20 ` [PATCH datacenter-manager v3 6/6] cli: admin: add `delete-token` option to delete token from remote Shan Shaji
2026-02-13 13:21 ` Lukas Wagner
2026-02-11 15:20 ` [PATCH proxmox v3 1/1] pve-api-types: generate missing `delete_token` method Shan Shaji
2026-02-18 17:55 ` Shan Shaji
2026-02-13 13:19 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGDV4EJF1TUW.1C5DBYMMLW8SD@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.