all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH proxmox-datacenter-manager v2 1/2] cli: add target-vmid parameter to remote_migrate_qemu
@ 2026-02-03  8:17 Maximiliano Sandoval
  2026-02-03  8:17 ` [PATCH proxmox-datacenter-manager v2 2/2] cli: add target-vmid parameter to remote_migrate_lxc Maximiliano Sandoval
  2026-02-05  9:11 ` applied: [PATCH proxmox-datacenter-manager v2 1/2] cli: add target-vmid parameter to remote_migrate_qemu Lukas Wagner
  0 siblings, 2 replies; 3+ messages in thread
From: Maximiliano Sandoval @ 2026-02-03  8:17 UTC (permalink / raw)
  To: pdm-devel

Adds a --target-vmid parameter to `proxmox-datacenter-manager-client pve
qemu remote-migrate`.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Differences from v1:

 - Add the optional argument to pve lxc remote-migrate too

 cli/client/src/pve.rs | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/cli/client/src/pve.rs b/cli/client/src/pve.rs
index 16289986..5c2a1abd 100644
--- a/cli/client/src/pve.rs
+++ b/cli/client/src/pve.rs
@@ -546,6 +546,10 @@ async fn migrate_qemu(
             },
             vmid: { schema: VMID_SCHEMA },
             target: { schema: REMOTE_ID_SCHEMA },
+            "target-vmid": {
+                optional: true,
+                schema: VMID_SCHEMA,
+            },
             delete: {
                 description: "Delete the original VM and related data after successful migration.",
                 optional: true,
@@ -587,6 +591,7 @@ async fn remote_migrate_qemu(
     node: Option<String>,
     vmid: u32,
     target: String,
+    target_vmid: Option<u32>,
     online: Option<bool>,
     delete: Option<bool>,
     map_storage: Vec<String>,
@@ -603,6 +608,9 @@ async fn remote_migrate_qemu(
     if let Some(bwlimit) = bwlimit {
         params = params.bwlimit(bwlimit);
     }
+    if let Some(target_vmid) = target_vmid {
+        params = params.target_vmid(target_vmid);
+    }
     for mapping in map_storage {
         let pos = mapping
             .find(':')
-- 
2.47.3





^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH proxmox-datacenter-manager v2 2/2] cli: add target-vmid parameter to remote_migrate_lxc
  2026-02-03  8:17 [PATCH proxmox-datacenter-manager v2 1/2] cli: add target-vmid parameter to remote_migrate_qemu Maximiliano Sandoval
@ 2026-02-03  8:17 ` Maximiliano Sandoval
  2026-02-05  9:11 ` applied: [PATCH proxmox-datacenter-manager v2 1/2] cli: add target-vmid parameter to remote_migrate_qemu Lukas Wagner
  1 sibling, 0 replies; 3+ messages in thread
From: Maximiliano Sandoval @ 2026-02-03  8:17 UTC (permalink / raw)
  To: pdm-devel

Adds a --target-vmid parameter to `proxmox-datacenter-manager-client pve
lxc remote-migrate`.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 cli/client/src/pve.rs | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/cli/client/src/pve.rs b/cli/client/src/pve.rs
index 5c2a1abd..19bd0980 100644
--- a/cli/client/src/pve.rs
+++ b/cli/client/src/pve.rs
@@ -918,6 +918,10 @@ async fn migrate_lxc(
             },
             vmid: { schema: VMID_SCHEMA },
             target: { schema: REMOTE_ID_SCHEMA },
+            "target-vmid": {
+                optional: true,
+                schema: VMID_SCHEMA,
+            },
             delete: {
                 description: "Delete the original VM and related data after successful migration.",
                 optional: true,
@@ -968,6 +972,7 @@ async fn remote_migrate_lxc(
     node: Option<String>,
     vmid: u32,
     target: String,
+    target_vmid: Option<u32>,
     online: Option<bool>,
     delete: Option<bool>,
     map_storage: Vec<String>,
@@ -986,6 +991,9 @@ async fn remote_migrate_lxc(
     if let Some(bwlimit) = bwlimit {
         params = params.bwlimit(bwlimit);
     }
+    if let Some(target_vmid) = target_vmid {
+        params = params.target_vmid(target_vmid);
+    }
     if restart {
         params = params.restart(true, timeout.map(Duration::from_secs));
     }
-- 
2.47.3





^ permalink raw reply	[flat|nested] 3+ messages in thread

* applied: [PATCH proxmox-datacenter-manager v2 1/2] cli: add target-vmid parameter to remote_migrate_qemu
  2026-02-03  8:17 [PATCH proxmox-datacenter-manager v2 1/2] cli: add target-vmid parameter to remote_migrate_qemu Maximiliano Sandoval
  2026-02-03  8:17 ` [PATCH proxmox-datacenter-manager v2 2/2] cli: add target-vmid parameter to remote_migrate_lxc Maximiliano Sandoval
@ 2026-02-05  9:11 ` Lukas Wagner
  1 sibling, 0 replies; 3+ messages in thread
From: Lukas Wagner @ 2026-02-05  9:11 UTC (permalink / raw)
  To: Maximiliano Sandoval, pdm-devel

On Tue Feb 3, 2026 at 9:17 AM CET, Maximiliano Sandoval wrote:
> Adds a --target-vmid parameter to `proxmox-datacenter-manager-client pve
> qemu remote-migrate`.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> Differences from v1:
>
>  - Add the optional argument to pve lxc remote-migrate too
>

applied both patches, thank you!

I slightly augmented the commit message with the info that the API
already supported this parameter and that this only adds the parameter
to the CLI client - as discussed off-list.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-05  9:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-03  8:17 [PATCH proxmox-datacenter-manager v2 1/2] cli: add target-vmid parameter to remote_migrate_qemu Maximiliano Sandoval
2026-02-03  8:17 ` [PATCH proxmox-datacenter-manager v2 2/2] cli: add target-vmid parameter to remote_migrate_lxc Maximiliano Sandoval
2026-02-05  9:11 ` applied: [PATCH proxmox-datacenter-manager v2 1/2] cli: add target-vmid parameter to remote_migrate_qemu Lukas Wagner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal