From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Datacenter Manager development discussion"
<pdm-devel@lists.proxmox.com>, "Shan Shaji" <s.shaji@proxmox.com>
Subject: [pdm-devel] applied: [PATCH datacenter-manager v3] ui: top entities: show hint message if there are no entities
Date: Tue, 13 Jan 2026 15:25:21 +0100 [thread overview]
Message-ID: <DFNJ40P0F81D.3RW6KSEIXVITA@proxmox.com> (raw)
In-Reply-To: <20260113125249.246276-1-s.shaji@proxmox.com>
On Tue Jan 13, 2026 at 1:52 PM CET, Shan Shaji wrote:
> When the entities list was empty, the dashboard did not display any
> message inside the Top Entities panels. This change adds a empty-state
> message so the panels provide proper feedback when no entries are
> available.
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
> changes since v2: Thanks @Lukas
> - Removed new line changes
> - Updated commit message.
> - Added `if` clause for better readability.
>
> changes since v1: Thanks @Dominik
> - Removed the extra property inside the TopEntities struct.
> - Added optional_child to the Panel to show the empty error message.
> - There was an empty space caused by the `TopEntities` component when the
> entities list was empty. Inorder to fix that now the TopEntities will
> only be rendered if the entities list is not empty.
>
Applied, thanks!
I folded a cargo fmt change into your commit, but nothing major.
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2026-01-13 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 12:52 [pdm-devel] " Shan Shaji
2026-01-13 14:25 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFNJ40P0F81D.3RW6KSEIXVITA@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.