[pve-devel] [PATCH manager] ui: migration: Improve grammar on error string

[pve-devel] [PATCH manager] ui: migration: Improve grammar on error string

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---

This was spotted while translating the UI:

 - Toward was selected instead of towards due to it being slithly more common in
   written american english, and also because the string was already too long.
 - This string was mentioned at https://forum.proxmox.com/threads/ha-non-strict-negative-resource-affinity.176757/#post-822473


 www/manager6/window/Migrate.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js
index ff80c70c..702009c3 100644
--- a/www/manager6/window/Migrate.js
+++ b/www/manager6/window/Migrate.js
@@ -428,7 +428,7 @@ Ext.define('PVE.window.Migrate', {
                     if (cause === 'resource-affinity') {
                         reasonText = Ext.String.format(
                             gettext(
-                                'HA resource {0} with negative affinity to VM on selected target node',
+                                'HA resource {0} has negative affinity toward a VM on the selected target node',
                             ),
                             sid,
                         );
@@ -518,7 +518,7 @@ Ext.define('PVE.window.Migrate', {
                     if (cause === 'resource-affinity') {
                         reasonText = Ext.String.format(
                             gettext(
-                                'HA resource {0} with negative affinity to container on selected target node',
+                                'HA resource {0} has negative affinity toward a container on the selected target node',
                             ),
                             sid,
                         );
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] ui: migration: Improve grammar on error string

[Daniel Kral]

On Fri Jan 9, 2026 at 9:30 AM CET, Maximiliano Sandoval wrote:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>
> This was spotted while translating the UI:
>
>  - Toward was selected instead of towards due to it being slithly more common in
>    written american english, and also because the string was already too long.
>  - This string was mentioned at https://forum.proxmox.com/threads/ha-non-strict-negative-resource-affinity.176757/#post-822473
>
>
>  www/manager6/window/Migrate.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js
> index ff80c70c..702009c3 100644
> --- a/www/manager6/window/Migrate.js
> +++ b/www/manager6/window/Migrate.js
> @@ -428,7 +428,7 @@ Ext.define('PVE.window.Migrate', {
>                      if (cause === 'resource-affinity') {
>                          reasonText = Ext.String.format(
>                              gettext(
> -                                'HA resource {0} with negative affinity to VM on selected target node',
> +                                'HA resource {0} has negative affinity toward a VM on the selected target node',

Unfortunately, "a VM" is misleading here, because `sid`, is the
_blocking_ HA resource, which is the reason why "VM" cannot be migrated
to the selected target node.

Sorry that it was misleading, but maybe we could either use "the VM" or
"VM {vmid}", where vmid = vm.get('vmid') I think in there.

>                              ),
>                              sid,
>                          );
> @@ -518,7 +518,7 @@ Ext.define('PVE.window.Migrate', {
>                      if (cause === 'resource-affinity') {
>                          reasonText = Ext.String.format(
>                              gettext(
> -                                'HA resource {0} with negative affinity to container on selected target node',
> +                                'HA resource {0} has negative affinity toward a container on the selected target node',
>                              ),
>                              sid,
>                          );

Same here



Otherwise the new text is better, thanks for sending!

Would be a nice-to-have to also improve the text for positive resource
affinity rules in a second patch in the same manner so it's less
confusing :)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel