all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pdm-devel] [PATCH proxmox-yew-comp] task description: use hyphen (-) between the id and the action
@ 2025-12-17 14:53 Lukas Wagner
  2025-12-19 12:41 ` [pdm-devel] supersede: " Lukas Wagner
  0 siblings, 1 reply; 2+ messages in thread
From: Lukas Wagner @ 2025-12-17 14:53 UTC (permalink / raw)
  To: pdm-devel

This way it matches the way we render task descriptions in the JS code.
For instance, PBS GC tasks are now rendered as

  "Datastore store2 - Garbage Collect"

instead of

  "Datastore store2 Garbage Collect"

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 src/utils/mod.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/utils/mod.rs b/src/utils/mod.rs
index 856297f..ca40fa3 100644
--- a/src/utils/mod.rs
+++ b/src/utils/mod.rs
@@ -184,7 +184,7 @@ impl<A: Display, B: Display> IntoTaskDescriptionRenderFn for (A, B) {
         let action = self.1.to_string();
         Box::new(move |_, id| {
             format!(
-                "{} {} {}",
+                "{} {} - {}",
                 task_type,
                 id.as_deref().unwrap_or("unknown"),
                 action
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pdm-devel] supersede: [PATCH proxmox-yew-comp] task description: use hyphen (-) between the id and the action
  2025-12-17 14:53 [pdm-devel] [PATCH proxmox-yew-comp] task description: use hyphen (-) between the id and the action Lukas Wagner
@ 2025-12-19 12:41 ` Lukas Wagner
  0 siblings, 0 replies; 2+ messages in thread
From: Lukas Wagner @ 2025-12-19 12:41 UTC (permalink / raw)
  To: Proxmox Datacenter Manager development discussion

On Wed Dec 17, 2025 at 3:53 PM CET, Lukas Wagner wrote:
> This way it matches the way we render task descriptions in the JS code.
> For instance, PBS GC tasks are now rendered as
>
>   "Datastore store2 - Garbage Collect"
>
> instead of
>
>   "Datastore store2 Garbage Collect"
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  src/utils/mod.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/utils/mod.rs b/src/utils/mod.rs
> index 856297f..ca40fa3 100644
> --- a/src/utils/mod.rs
> +++ b/src/utils/mod.rs
> @@ -184,7 +184,7 @@ impl<A: Display, B: Display> IntoTaskDescriptionRenderFn for (A, B) {
>          let action = self.1.to_string();
>          Box::new(move |_, id| {
>              format!(
> -                "{} {} {}",
> +                "{} {} - {}",
>                  task_type,
>                  id.as_deref().unwrap_or("unknown"),
>                  action

superseded:

https://lore.proxmox.com/all/20251219124031.223144-1-l.wagner@proxmox.com/T/#u


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-19 12:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-17 14:53 [pdm-devel] [PATCH proxmox-yew-comp] task description: use hyphen (-) between the id and the action Lukas Wagner
2025-12-19 12:41 ` [pdm-devel] supersede: " Lukas Wagner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal