From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Datacenter Manager development discussion"
<pdm-devel@lists.proxmox.com>,
"Dominik Csapak" <d.csapak@proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager] ui: add download button for system report
Date: Tue, 16 Dec 2025 14:50:32 +0100 [thread overview]
Message-ID: <DEZOU3SM9EF7.1CX6LTFNT6IRI@proxmox.com> (raw)
In-Reply-To: <20251210140008.3046928-1-d.csapak@proxmox.com>
On Wed Dec 10, 2025 at 2:59 PM CET, Dominik Csapak wrote:
> by simply setting the 'href' of an 'a' tag to be the report as inline
> data, like we do on PVE/PBS with a slight difference:
>
> in PVE/PBS we create an 'a' tag dynamically on button click, but here we
> create the a tag when we have the data and wrap a button without click
> handler, so the click on the button triggers the download of the 'a'
> tag.
>
> Refactor the `get_nodename` function to another place where we can
> access it from here.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Looks good to me and works as expected.
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-12-16 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 13:59 Dominik Csapak
2025-12-16 13:50 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DEZOU3SM9EF7.1CX6LTFNT6IRI@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.