Re: [pdm-devel] [PATCH proxmox/datacenter-manager v2 00/14] initial auto-installer integration

["Christoph Heiss" <c.heiss@proxmox.com>]

On Fri Dec 5, 2025 at 12:53 PM CET, Thomas Lamprecht wrote:
> Am 05.12.25 um 12:25 schrieb Christoph Heiss:
[..]
>> Serving TOML from an endpoint under /api2/json/ obviously is rather
>> wrong, so I'm definitely open for suggestions.
>> We probably also don't want to implement `/api2/toml/` if I'd have to
>> guess (or would that be possible selectively, i.e. just for this one
>> endpoint?).
>
> Making that selective should be possible in any case; another option
> might be to add a "raw" one where the endpoints does the serialization
> and returns a string directly, that would at least make it a bit more
> flexible for the future; but not something we need to jump the gun now,
> especially as this needs some care w.r.t. security – just giving the code
> full control over content/type and content might be a bad idea; but the
> content type could be part of the API schema definition.

Having the selective "raw" endpoint feature with the actual content type
part of the schema definition sounds definitely workable! I'll see if
it's possible to implement with reasonable effort.

>
>> Adding JSON support to proxmox-fetch-answer is on my list, but this
>> would still be needed if we want to keep compatibility with older ISOs.
>
> FWIW; in general I'd be fine with this only working with newer ISOs, at
> least as long as we do have published an ISO that has support for all our
> projects; if we can support older ones without having to bend backwards
> too much it would be naturally great too, and for that returning TOML
> for json format can IMO be an OK stop-gap if the "raw" format is too
> much scope creep. It would be nice if we could make that opt-in so that
> newer ISOs can default to use JSON directly if they support it.

My plan here would have been using the `Accept` header, i.e.
(newer) proxmox-fetch-answer would include
`Accept: application/json, application/toml;q=0.5`, so that JSON is
preferred if available. If the header is missing, TOML is sent.


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel