From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Datacenter Manager development discussion"
<pdm-devel@lists.proxmox.com>,
"Dominik Csapak" <d.csapak@proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager 0/5] some ui polishing changes
Date: Thu, 04 Dec 2025 16:23:04 +0100 [thread overview]
Message-ID: <DEPJAEZRT6EU.345O5KZ287C5D@proxmox.com> (raw)
In-Reply-To: <20251204142451.2992215-1-d.csapak@proxmox.com>
On Thu Dec 4, 2025 at 3:20 PM CET, Dominik Csapak wrote:
> These 5 changes are just small polishing things, from layouting, to
> showing loading indcators, etc.
>
> They're all independent of each other, so feel free to pick & choose
> what looks right and appropriate.
>
> Dominik Csapak (5):
> ui: pve: remove overview: allow line-breaks for long lines
> ui: remote updates: show progress on 'refresh all'
> ui: configuration: subscription: improve behavior on 'check'
> ui: views: add message on empty layouts
> ui: main menu: use different icon for pbs remotes
>
> ui/src/configuration/subscription_panel.rs | 42 ++++++++--------
> ui/src/dashboard/view/row_view.rs | 13 +++++
> ui/src/main_menu.rs | 5 +-
> ui/src/pve/remote_overview.rs | 58 +++++++++++++---------
> ui/src/remotes/updates.rs | 35 ++++++++++---
> 5 files changed, 102 insertions(+), 51 deletions(-)
These make sense to me and work as expected. See the two last patches
for some additional notes, otherwise:
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-12-04 15:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 14:20 Dominik Csapak
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 1/5] ui: pve: remove overview: allow line-breaks for long lines Dominik Csapak
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 2/5] ui: remote updates: show progress on 'refresh all' Dominik Csapak
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 3/5] ui: configuration: subscription: improve behavior on 'check' Dominik Csapak
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 4/5] ui: views: add message on empty layouts Dominik Csapak
2025-12-04 15:18 ` Lukas Wagner
2025-12-04 14:20 ` [pdm-devel] [RFC PATCH datacenter-manager 5/5] ui: main menu: use different icon for pbs remotes Dominik Csapak
2025-12-04 15:21 ` Lukas Wagner
2025-12-04 20:01 ` Thomas Lamprecht
2025-12-05 7:35 ` Dominik Csapak
2025-12-04 15:23 ` Lukas Wagner [this message]
2025-12-04 20:01 ` [pdm-devel] partially-applied: [PATCH datacenter-manager 0/5] some ui polishing changes Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DEPJAEZRT6EU.345O5KZ287C5D@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.