[pdm-devel] [PATCH yew-comp] pve: firewall: make the node enable option default to true

[pdm-devel] [PATCH yew-comp] pve: firewall: make the node enable option default to true

[Shannon Sterz]

otherwise the display in pdm will be inconsistent.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 src/configuration/pve/firewall_options_node_panel.rs | 2 +-
 src/form/pve/firewall_property/mod.rs                | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/configuration/pve/firewall_options_node_panel.rs b/src/configuration/pve/firewall_options_node_panel.rs
index b74bba1..4f5cb2b 100644
--- a/src/configuration/pve/firewall_options_node_panel.rs
+++ b/src/configuration/pve/firewall_options_node_panel.rs
@@ -84,7 +84,7 @@ pub struct FirewallOptionsNodeComp {
 
 fn properties(mobile: bool) -> Vec<EditableProperty> {
     vec![
-        firewall_property::enable_property(mobile),
+        firewall_property::enable_node_property(mobile),
         firewall_property::nosmurfs_property(mobile),
         firewall_property::tcpflags_property(mobile),
         firewall_property::ndp_property(mobile),
diff --git a/src/form/pve/firewall_property/mod.rs b/src/form/pve/firewall_property/mod.rs
index 38767d5..e14725b 100644
--- a/src/form/pve/firewall_property/mod.rs
+++ b/src/form/pve/firewall_property/mod.rs
@@ -27,6 +27,10 @@ pub fn enable_property(mobile: bool) -> EditableProperty {
     EditableProperty::new_bool("enable", tr!("Enable Firewall"), false, mobile).required(true)
 }
 
+pub fn enable_node_property(mobile: bool) -> EditableProperty {
+    EditableProperty::new_bool("enable", tr!("Enable Firewall"), true, mobile).required(true)
+}
+
 /// cluster wide enable firewall (stored as integer instead of bool)
 pub fn cluster_enable_property(mobile: bool) -> EditableProperty {
     EditableProperty::new_bool("enable", tr!("Enable Firewall"), false, mobile)
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH yew-comp] pve: firewall: make the node enable option default to true

[Shannon Sterz]

for reference, this got applied: https://git.proxmox.com/?p=ui/proxmox-yew-comp.git;a=commit;h=5a18df70ebb60c1f5f86d88ff0fff4c5a4a00fb6

On Wed Dec 3, 2025 at 3:15 PM CET, Shannon Sterz wrote:
> otherwise the display in pdm will be inconsistent.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  src/configuration/pve/firewall_options_node_panel.rs | 2 +-
>  src/form/pve/firewall_property/mod.rs                | 4 ++++
>  2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/configuration/pve/firewall_options_node_panel.rs b/src/configuration/pve/firewall_options_node_panel.rs
> index b74bba1..4f5cb2b 100644
> --- a/src/configuration/pve/firewall_options_node_panel.rs
> +++ b/src/configuration/pve/firewall_options_node_panel.rs
> @@ -84,7 +84,7 @@ pub struct FirewallOptionsNodeComp {
>
>  fn properties(mobile: bool) -> Vec<EditableProperty> {
>      vec![
> -        firewall_property::enable_property(mobile),
> +        firewall_property::enable_node_property(mobile),
>          firewall_property::nosmurfs_property(mobile),
>          firewall_property::tcpflags_property(mobile),
>          firewall_property::ndp_property(mobile),
> diff --git a/src/form/pve/firewall_property/mod.rs b/src/form/pve/firewall_property/mod.rs
> index 38767d5..e14725b 100644
> --- a/src/form/pve/firewall_property/mod.rs
> +++ b/src/form/pve/firewall_property/mod.rs
> @@ -27,6 +27,10 @@ pub fn enable_property(mobile: bool) -> EditableProperty {
>      EditableProperty::new_bool("enable", tr!("Enable Firewall"), false, mobile).required(true)
>  }
>
> +pub fn enable_node_property(mobile: bool) -> EditableProperty {
> +    EditableProperty::new_bool("enable", tr!("Enable Firewall"), true, mobile).required(true)
> +}
> +
>  /// cluster wide enable firewall (stored as integer instead of bool)
>  pub fn cluster_enable_property(mobile: bool) -> EditableProperty {
>      EditableProperty::new_bool("enable", tr!("Enable Firewall"), false, mobile)



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel