From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>
Cc: pdm-devel@lists.proxmox.com
Subject: Re: [pdm-devel] [PATCH yew-comp] pve: firewall: make the node enable option default to true
Date: Thu, 04 Dec 2025 09:22:59 +0100 [thread overview]
Message-ID: <DEPACS1S65W3.PDYHZ9C81XPF@proxmox.com> (raw)
In-Reply-To: <20251203141552.336623-2-s.sterz@proxmox.com>
for reference, this got applied: https://git.proxmox.com/?p=ui/proxmox-yew-comp.git;a=commit;h=5a18df70ebb60c1f5f86d88ff0fff4c5a4a00fb6
On Wed Dec 3, 2025 at 3:15 PM CET, Shannon Sterz wrote:
> otherwise the display in pdm will be inconsistent.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> src/configuration/pve/firewall_options_node_panel.rs | 2 +-
> src/form/pve/firewall_property/mod.rs | 4 ++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/configuration/pve/firewall_options_node_panel.rs b/src/configuration/pve/firewall_options_node_panel.rs
> index b74bba1..4f5cb2b 100644
> --- a/src/configuration/pve/firewall_options_node_panel.rs
> +++ b/src/configuration/pve/firewall_options_node_panel.rs
> @@ -84,7 +84,7 @@ pub struct FirewallOptionsNodeComp {
>
> fn properties(mobile: bool) -> Vec<EditableProperty> {
> vec![
> - firewall_property::enable_property(mobile),
> + firewall_property::enable_node_property(mobile),
> firewall_property::nosmurfs_property(mobile),
> firewall_property::tcpflags_property(mobile),
> firewall_property::ndp_property(mobile),
> diff --git a/src/form/pve/firewall_property/mod.rs b/src/form/pve/firewall_property/mod.rs
> index 38767d5..e14725b 100644
> --- a/src/form/pve/firewall_property/mod.rs
> +++ b/src/form/pve/firewall_property/mod.rs
> @@ -27,6 +27,10 @@ pub fn enable_property(mobile: bool) -> EditableProperty {
> EditableProperty::new_bool("enable", tr!("Enable Firewall"), false, mobile).required(true)
> }
>
> +pub fn enable_node_property(mobile: bool) -> EditableProperty {
> + EditableProperty::new_bool("enable", tr!("Enable Firewall"), true, mobile).required(true)
> +}
> +
> /// cluster wide enable firewall (stored as integer instead of bool)
> pub fn cluster_enable_property(mobile: bool) -> EditableProperty {
> EditableProperty::new_bool("enable", tr!("Enable Firewall"), false, mobile)
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-12-04 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 14:15 Shannon Sterz
2025-12-04 8:22 ` Shannon Sterz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DEPACS1S65W3.PDYHZ9C81XPF@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.