From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Michael Köppl" <m.koeppl@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu-server 1/1] create_vm: assume HA state 'started' when live-restoring guests
Date: Thu, 27 Nov 2025 16:42:02 +0100 [thread overview]
Message-ID: <DEJLB4R7443W.2EYXIOHU61AIR@proxmox.com> (raw)
In-Reply-To: <20251120163446.179671-1-m.koeppl@proxmox.com>
Superseded-by: https://lore.proxmox.com/pve-devel/20251127154041.194423-1-m.koeppl@proxmox.com
On Thu Nov 20, 2025 at 5:34 PM CET, Michael Köppl wrote:
> To avoid shutting down the VM when performing a live-restore, consider
> live-restore=1 to translate to a HA state of 'started', similar to
> start=1.
>
> Reported-by: Fiona Ebner <f.ebner@proxmox.com>
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
> Used defined-or since in pve-manager, we only ever set one of the two
> values and in any other case I'd give precedence to the 'start'
> parameter if it is explicitly set.
>
> src/PVE/API2/Qemu.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
> index c580bf63..33427ca7 100644
> --- a/src/PVE/API2/Qemu.pm
> +++ b/src/PVE/API2/Qemu.pm
> @@ -1237,7 +1237,8 @@ __PACKAGE__->register_method({
> my $bwlimit = extract_param($param, 'bwlimit');
> my $force = extract_param($param, 'force');
> my $pool = extract_param($param, 'pool');
> - my $start_after_create = extract_param($param, 'start');
> + my $start_after_create = extract_param($param, 'start')
> + // extract_param($param, 'live-restore');
> my $ha_managed = extract_param($param, 'ha-managed');
> my $storage = extract_param($param, 'storage');
> my $unique = extract_param($param, 'unique');
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-11-27 15:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 16:34 Michael Köppl
2025-11-21 9:45 ` Fiona Ebner
2025-11-21 10:05 ` Thomas Lamprecht
2025-11-21 10:15 ` Fiona Ebner
2025-11-21 10:24 ` Thomas Lamprecht
2025-11-21 10:32 ` Fiona Ebner
2025-11-21 11:13 ` Thomas Lamprecht
2025-11-25 13:44 ` Michael Köppl
2025-11-27 15:42 ` Michael Köppl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DEJLB4R7443W.2EYXIOHU61AIR@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.