Re: [pdm-devel] [PATCH proxmox{, -datacenter-manager, -yew-comp} v5 00/12] add basic integration of PVE firewall

From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Datacenter Manager development discussion"
	<pdm-devel@lists.proxmox.com>,
	"Hannes Laimer" <h.laimer@proxmox.com>
Subject: Re: [pdm-devel] [PATCH proxmox{, -datacenter-manager, -yew-comp} v5 00/12] add basic integration of PVE firewall
Date: Thu, 27 Nov 2025 14:38:06 +0100	[thread overview]
Message-ID: <DEJIO8GZO8XD.C8XRZ2X0QXJR@proxmox.com> (raw)
In-Reply-To: <20251127092209.213535-1-h.laimer@proxmox.com>

On Thu Nov 27, 2025 at 10:21 AM CET, Hannes Laimer wrote:
> Generally loading the status involves 2 requests per entity, so the PDM
> server has to do quite a bit of work collecting all the relevant data.
> That is the reason we have multiple status endpoints
>  - for all pve remotes
>  - for a specific remote
>  - for a specific node
> a bit more context on the commit adding these endpoints. With these we
> can limit the number of requests the PDM potentially has to do. In this
> context a cache could also make sense, should be somewhat straight
> forward integrating something like Dominik proposed in [1]. But since
> these are configs, caches would have to be really short lived, but still,
> they could help with different useres requesting the same data at close
> to the same time.
>
> Firewall options edit form and the firewall rules tables were added to
> yew-comp as they are not necesarrily PDM specific. I tried having them
> in a way so it would not be too complicated reusing them in other places
> at some point.
>
> This also includes an updated pve-api.json, some api endpoint specs did
> require minor adjustments so they'd work with the type generator.
> Generally this is build with the latest master of proxmox-yew-comp and
> proxmox-yew-widget-toolkit.
>
> Notes: node or guest firewalls could be enabled, but end up being masked
> by the cluster setting. I tried visualizing that by having the checkmark
> normal if masked and green if not.

Looking really good. Gave this another spin on the latest master.
Noticed that there are some error messages in the browser console, see
my other reply - but this can also be fixed in a trivial followup-patch
(or also when applying).

Tested-by: Lukas Wagner <l.wagner@proxmox.com>

_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel