From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox 1/5] proxmox-upgrade-checks: fix meta package version check
Date: Mon, 24 Nov 2025 10:56:39 +0100 [thread overview]
Message-ID: <DEGU1XUD5NMO.R3PAV1RHO43N@proxmox.com> (raw)
In-Reply-To: <DEGU1341QGIZ.1I1F8IGH8MHE9@proxmox.com>
On Mon Nov 24, 2025 at 10:54 AM CET, Shannon Sterz wrote:
> On Thu Nov 20, 2025 at 4:08 PM CET, Stefan Hanreich wrote:
>> On 11/20/25 4:03 PM, Shannon Sterz wrote:
>>> ah thanks for catching this, i somehow missed this, i'll need to ping my
>>> series finally switching pdm over to this crate again. anyhow, for now
>>> this is fine, though i would appreciate this approach a bit more:
>>>
>>> ```
>>> if let Some(old_version) = meta_pkg.and_then(|m| m.old_version.as_ref()) {
>>> let pkg_version = Regex::new(r"^(\d+)\.(\d+)[.-](\d+)")?;
>>> let captures = pkg_version.captures(old_version);
>>> ```
>>
>> yeah, this seems indeed better - Idk why I always default to map over
>> and_then in such cases :P
as discussed off-list i'll adapt this patch as outlined here and add it
to my series trying to factor out the upgrading checking logic so we
can unify it.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-11-24 9:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 14:50 [pbs-devel] [RFC proxmox{, -datacenter-manager} 0/6] Add fallback variants to PBS API types Stefan Hanreich
2025-11-20 14:50 ` [pbs-devel] [PATCH proxmox 1/5] proxmox-upgrade-checks: fix meta package version check Stefan Hanreich
2025-11-20 15:04 ` Shannon Sterz
2025-11-20 15:08 ` Stefan Hanreich
[not found] ` <DEGU1341QGIZ.1I1F8IGH8MHE9@proxmox.com>
2025-11-24 9:56 ` Shannon Sterz [this message]
2025-11-20 14:50 ` [pbs-devel] [PATCH proxmox 2/5] proxmox-fixed-string: extract FixedString into own crate Stefan Hanreich
2025-11-20 14:50 ` [pbs-devel] [PATCH proxmox 3/5] proxmox-fixed-string: implement hash trait Stefan Hanreich
2025-11-20 14:50 ` [pbs-devel] [PATCH proxmox 4/5] pve-api-types: add proxmox-fixed-string Stefan Hanreich
2025-11-20 14:50 ` [pbs-devel] [PATCH proxmox 5/5] pbs-api-types: add fallback variants to enums in public API Stefan Hanreich
2025-11-20 14:50 ` [pbs-devel] [PATCH proxmox-datacenter-manager 1/1] tree-wide: add enum fallback variants for pbs api types Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DEGU1XUD5NMO.R3PAV1RHO43N@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.