Re: [pdm-devel] [PATCH datacenter-manager 3/4] ui: pbs: move node overview to tab and add update tab

["Lukas Wagner" <l.wagner@proxmox.com>]

On Thu Nov 20, 2025 at 4:52 PM CET, Michael Köppl wrote:
>> +struct PbsNodePanelComp;
>> +
>> +impl yew::Component for PbsNodePanelComp {
>> +    type Message = ();
>> +    type Properties = PbsNodePanel;
>> +
>> +    fn create(_ctx: &yew::Context<Self>) -> Self {
>> +        Self
>> +    }
>> +
>> +    fn changed(&mut self, ctx: &Context<Self>, old_props: &Self::Properties) -> bool {
>> +        let props = ctx.props();
>> +
>> +        props.remote != old_props.remote
>> +    }
>> +
>> +    fn view(&self, ctx: &yew::Context<Self>) -> yew::Html {
>> +        let props = ctx.props();
>> +
>> +        let title: Html = Row::new()
>> +            .gap(2)
>> +            .class(AlignItems::Baseline)
>> +            .with_child(Fa::new("building"))
>> +            .with_child(tr!("Node"))
>
> nit: I might not be entirely up-to-date on the nomenclature, but is
> "Node" correct here? IMO it also looked a bit off, having
> "Remote '<name>'" on the left panel and then just "Node" on the right
> panel. Perhaps "Backup Server", "Proxmox Backup Server", or the name of
> the PBS might fit better in this case? Was there a reason to use "Node"?
>

Thank you for the review, first and foremost!

Good catch - I also wasn't super sure about what to put here.
Main reason why I went with 'Node' is consistency with the PVE variant
of the view. There, the label is 'Node {nodename}', just so to clarify
that the data in the graphs is from the specific node selected in the
resource tree on the left-hand side.
For PBS, we only have one node per remote (for which we also don't
really know the hostname); and 'Node localhost' is not really that
useful - hence I just went with 'Node'.

Would you still rather use some other string here?


>> +            .into();
>> +
>> +        TabPanel::new()
>> +            .class(pwt::css::FlexFit)
>
>
>
> _______________________________________________
> pdm-devel mailing list
> pdm-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel