Re: [pdm-devel] [PATCH datacenter-manager 0/4] add 'Updates' tab for PBS remotes

["Michael Köppl" <m.koeppl@proxmox.com>]

Added my local PBS to test the update tab. Then:
- update packages through the UI
- checked that the upgrade button opens the correct page on my PBS
- changelogs per package are displayed correctly

Everything seemed to work as expected. Also had a look at the code.
Since it's mostly similar code to the PVE implementation, I mainly
focused on PBS specifics like API endpoints, etc. Noted 1 nit on the
individual patch, but other than that lgtm!

Tested-by: Michael Köppl <m.koeppl@proxmox.com>
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>

On Thu Nov 20, 2025 at 11:36 AM CET, Lukas Wagner wrote:
> This is achieved by moving the existing node overview to a new 'Overview' tab and
> then adding a new 'Updates' tab - the same way it is already implemented
> for PVE remotes.
>
> Moved and renamed some things as they made sense to me, mostly for
> consistency reasons.
>
> Lukas Wagner (4):
>   ui: move pbs node overview panel from pbs::remote to
>     pbs::node::overview
>   ui: pbs: rename RemoteOverviewPanel to PbsNodeOverviewPanel
>   ui: pbs: move node overview to tab and add update tab
>   ui: pve: rename NodePanel to PveNodePanel
>
>  ui/src/pbs/mod.rs                          |   6 +-
>  ui/src/pbs/node/mod.rs                     | 115 +++++++++++++++++++++
>  ui/src/pbs/{remote.rs => node/overview.rs} |  31 +++---
>  ui/src/pve/mod.rs                          |   2 +-
>  ui/src/pve/node/mod.rs                     |  20 ++--
>  ui/src/pve/node/overview.rs                |  20 ++--
>  6 files changed, 151 insertions(+), 43 deletions(-)
>  create mode 100644 ui/src/pbs/node/mod.rs
>  rename ui/src/pbs/{remote.rs => node/overview.rs} (92%)



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel