Re: [pdm-devel] [PATCH datacenter-manager v3 00/18] enable custom views on the UI

["Shannon Sterz" <s.sterz@proxmox.com>]

one high level comment:

due to how the row layout works, it's actually possible to adjust the
flex values of certain elements so that one logical rew appears as
multiple visual rows. this behaves fairly unintuitively imo. it's not
too bad, but it could be a little irritating.

other than that and the other comments i send, consider this series:

Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>
Tested-by: Shannon Sterz <s.sterz@proxmox.com>

On Mon Nov 17, 2025 at 1:44 PM CET, Dominik Csapak wrote:
> With this series, users are able to add/edit/delete custom views.
>
> A new 'Views' menu entry is added where the CRUD ui sits, and an entry
> for each view below it.
>
> The includes/excludes are editable from the CRUD grid, and the layout is
> editable in the view itself.
>
> For now i opted to make the layout part of the `ViewConfig` struct, but
> as a simple json-string only, because we're not able to use the
> api-macro (for now; the rust enum features i use are currently not
> supported there). To verify it regardless, we try to deserialize
> the layout in the add/update call, so that no wrong layout can enter
> the config (via the api).
>
> The patch 'ui: dashboard: prepare view for editint custom views'
> is adapted from my last series, but all other changes are new,
> especially the CRUD api.
>
> There are still a few parts missing/wrong, namely
> * while the api is prepared, clicking on guest status items does not
>   yet populate the search field with a '+view:foo' term
> * subscriptions panels are still added by default when none is in the
>   layout itself (the plan is to move the subscription notice)
> * i'm still working on making the 'resource tree' a full widget that
>   users can add to their views.
>
> changes from v2:
> * fixed 'verbose' property for subscriptions api call
> * adapted to PveSdnZone -> PveNetwork renaming
> * added validators for filter fields
>   (so that the user sees it's invalid)
>
> changes from v1:
> * rebase on master, lukas v5 was applied
>
> Dominik Csapak (18):
>   lib: pdm-config: views: add locking/saving methods
>   lib: api-types: add 'layout' property to ViewConfig
>   server: api: implement CRUD api for views
>   server: api: resources: add 'view' category to search syntax
>   ui: remote selector: allow forcing of value
>   ui: dashboard types: add missing 'default' to de-serialization
>   ui: dashboard: status row: add optional 'editing state'
>   ui: dashboard: prepare view for editing custom views
>   ui: views: implement view loading from api
>   ui: views: make 'view' name property optional
>   ui: views: add 'view' parameter to api calls
>   ui: views: save updated layout to backend
>   ui: add view list context
>   ui: configuration: add view CRUD panels
>   ui: main menu: add optional view_list property
>   ui: load view list on page init
>   lib/ui: move views types to pdm-api-types
>   server: api: views: check layout string for validity
>
>  lib/pdm-api-types/src/resource.rs     |   7 +
>  lib/pdm-api-types/src/views.rs        |  90 ++++-
>  lib/pdm-config/src/views.rs           |  22 +-
>  server/src/api/config/mod.rs          |   2 +
>  server/src/api/config/views.rs        | 265 +++++++++++++
>  server/src/api/resources.rs           |  19 +-
>  server/src/views/mod.rs               |   2 +-
>  server/src/views/tests.rs             |  15 +
>  ui/Cargo.toml                         |   2 +-
>  ui/css/pdm.scss                       |   4 +
>  ui/src/configuration/mod.rs           |   2 +
>  ui/src/configuration/view_edit.rs     |   4 +
>  ui/src/configuration/views.rs         | 320 ++++++++++++++++
>  ui/src/dashboard/mod.rs               |   2 -
>  ui/src/dashboard/status_row.rs        |  60 ++-
>  ui/src/dashboard/top_entities.rs      |   3 +-
>  ui/src/dashboard/types.rs             |  79 ----
>  ui/src/dashboard/view.rs              | 389 +++++++++++--------
>  ui/src/dashboard/view/row_element.rs  | 130 +++++++
>  ui/src/dashboard/view/row_view.rs     | 520 +++++++++++++++++++++++++-
>  ui/src/lib.rs                         |   3 +
>  ui/src/main.rs                        |  47 ++-
>  ui/src/main_menu.rs                   |  57 ++-
>  ui/src/pve/mod.rs                     |   9 +
>  ui/src/view_list_context.rs           |  31 ++
>  ui/src/widget/mod.rs                  |   6 +
>  ui/src/widget/remote_selector.rs      |   6 +
>  ui/src/widget/view_filter_selector.rs | 393 +++++++++++++++++++
>  ui/src/widget/view_selector.rs        |  55 +++
>  29 files changed, 2288 insertions(+), 256 deletions(-)
>  create mode 100644 server/src/api/config/views.rs
>  create mode 100644 ui/src/configuration/view_edit.rs
>  create mode 100644 ui/src/configuration/views.rs
>  delete mode 100644 ui/src/dashboard/types.rs
>  create mode 100644 ui/src/dashboard/view/row_element.rs
>  create mode 100644 ui/src/view_list_context.rs
>  create mode 100644 ui/src/widget/view_filter_selector.rs
>  create mode 100644 ui/src/widget/view_selector.rs



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel