Re: [pdm-devel] [PATCH datacenter-manager v3 12/18] ui: views: save updated layout to backend

["Shannon Sterz" <s.sterz@proxmox.com>]

one comment in-line.

On Mon Nov 17, 2025 at 1:44 PM CET, Dominik Csapak wrote:
> when we get a 'LayoutUpdate' message, update the view config with the
> new layout.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  ui/src/dashboard/view.rs | 32 ++++++++++++++++++++++++++++++--
>  1 file changed, 30 insertions(+), 2 deletions(-)
>
> diff --git a/ui/src/dashboard/view.rs b/ui/src/dashboard/view.rs
> index 404c984f..9bf5dfc7 100644
> --- a/ui/src/dashboard/view.rs
> +++ b/ui/src/dashboard/view.rs
> @@ -6,7 +6,7 @@ use js_sys::Date;
>  use serde_json::{json, Value};
>  use yew::virtual_dom::{VComp, VNode};
>
> -use proxmox_yew_comp::http_get;
> +use proxmox_yew_comp::{http_get, http_put};
>  use pwt::css;
>  use pwt::prelude::*;
>  use pwt::props::StorageLocation;
> @@ -83,6 +83,7 @@ pub enum Msg {
>      ConfigWindow(bool), // show
>      UpdateConfig(RefreshConfig),
>      LayoutUpdate(ViewLayout),
> +    UpdateResult(Result<(), Error>),
>  }
>
>  struct ViewComp {
> @@ -103,6 +104,7 @@ struct ViewComp {
>      show_create_wizard: Option<RemoteType>,
>
>      editing_state: SharedState<Vec<EditingMessage>>,
> +    update_result: LoadResult<(), Error>,
>  }
>
>  fn render_widget(
> @@ -304,6 +306,7 @@ impl Component for ViewComp {
>              show_create_wizard: None,
>
>              editing_state: SharedState::new(Vec::new()),
> +            update_result: LoadResult::new(),
>          }
>      }
>
> @@ -360,11 +363,30 @@ impl Component for ViewComp {
>                  self.show_config_window = false;
>              }
>              Msg::LayoutUpdate(view_layout) => {
> -                // FIXME: update backend layout
> +                let link = ctx.link().clone();
>                  if let Some(template) = &mut self.template.data {
>                      template.layout = view_layout;
> +                    if let Some(view) = &ctx.props().view {
> +                        let view = view.to_string();
> +                        match serde_json::to_string(&template) {
> +                            Ok(layout_str) => self.async_pool.spawn(async move {
> +                                let params = json!({
> +                                    "layout": layout_str,
> +                                });
> +
> +                                let res =
> +                                    http_put::<()>(format!("/config/views/{view}"), Some(params))
> +                                        .await;

nit: `()` can be inferred here, so you can drop the `::<()>`.

> +                                link.send_message(Msg::UpdateResult(res));
> +                            }),
> +                            Err(err) => self.template.update(Err(err.into())),
> +                        };
> +                    }
>                  }
>              }
> +            Msg::UpdateResult(res) => {
> +                self.update_result.update(res);
> +            }
>          }
>          true
>      }
> @@ -452,6 +474,12 @@ impl Component for ViewComp {
>                  .as_ref()
>                  .map(|err| error_message(&err.to_string())),
>          );
> +        view.add_optional_child(
> +            self.update_result
> +                .error
> +                .as_ref()
> +                .map(|err| error_message(&err.to_string())),
> +        );
>          view.add_optional_child(self.show_config_window.then_some({
>              let refresh_config_id = match &props.view {
>                  Some(view) => format!("view-{view}"),



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel