Re: [pve-devel] [PATCH manager 7/7] ui: cpu flag selector: query CPU flag list via API

["Daniel Kral" <d.kral@proxmox.com>]

On Fri Oct 31, 2025 at 1:27 PM CET, Fiona Ebner wrote:
> There is coupling between the store and value for the top-level grid,
> which has a field mixin. Becuase of this, the setValue() method needs
> to update the 'state' value for the records in the store accordingly.
> This can however only be done if the store is already loaded, so the
> store gets a refresh() callback. It also remembers which value it was
> already adjusted for for potential subsequent setValue() calls.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Happy to hear suggestions if this is too involved already! The grid
> itself is a field (via mixin) and the 'state' values in the store are
> coupled with the field value, so I couldn't figure out a simpler way
> yet.

-->8 snip 8<---

>      getValue: function () {
>          let me = this;
>          let store = me.getStore();
> +
> +        if (!store.isLoaded()) {
> +            return me.value;
> +        }
> +
>          let flags = '';
>  
>          // ExtJS does not has a nice getAllRecords interface for stores :/
>          store.queryBy(Ext.returnTrue).each(function (rec) {

unrelated to the patch, but shouldn't `store.getData()` return all the
records? `store.getData().getSource()` would be the equivalent, but as
the store for cpu capabilities isn't filtered right now, the former
should work.

>              let s = rec.get('state');
>              if (s && s !== '=') {
> -                let f = rec.get('flag');
> +                let f = rec.get('name');
>                  if (flags === '') {
>                      flags = s + f;
>                  } else {
> @@ -88,33 +68,41 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
>          return flags;
>      },
>  
> -    setValue: function (value) {
> +    // Adjusts the store for the current value and determines the unkown flags based on what the
> +    // store does not know.
> +    adjustStoreForValue: function () {
>          let me = this;
>          let store = me.getStore();
> -
> -        me.value = value || '';
> +        let value = me.value;
>  
>          me.unkownFlags = [];
>  
> -        me.getStore()
> -            .queryBy(Ext.returnTrue)
> -            .each(function (rec) {
> -                rec.set('state', '=');
> -            });
> +        store.queryBy(Ext.returnTrue).each((rec) => rec.set('state', '='));

same here

>  
>          let flags = value ? value.split(';') : [];
>          flags.forEach(function (flag) {
>              let sign = flag.substr(0, 1);
>              flag = flag.substr(1);
>  
> -            let rec = store.findRecord('flag', flag, 0, false, true, true);
> +            let rec = store.findRecord('name', flag, 0, false, true, true);
>              if (rec !== null) {
>                  rec.set('state', sign);
>              } else {
>                  me.unkownFlags.push(flag);
>              }
>          });
> -        store.reload();
> +
> +        store.adjustedForValue = value;
> +    },
> +
> +    setValue: function (value) {
> +        let me = this;
> +
> +        me.value = value || '';
> +
> +        if (me.getStore().isLoaded()) {
> +            me.adjustForValue();

Shouldn't this be `me.adjustStoreForValue();`? :)

I haven't yet found a way to trigger this though - neither in the Create
wizard nor the CPU modal with and without values - but maybe my
debugging strategy here is a bit wrong. How did you trigger it?

> +        } // if not yet loaded, the store will trigger the function
>  
>          let res = me.mixins.field.setValue.call(me, value);
>  
> @@ -184,11 +172,11 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
>              },
>          },
>          {
> -            dataIndex: 'flag',
> +            dataIndex: 'name',
>              width: 100,
>          },
>          {
> -            dataIndex: 'desc',
> +            dataIndex: 'description',
>              cellWrap: true,
>              flex: 1,
>          },
> @@ -197,12 +185,8 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
>      initComponent: function () {
>          let me = this;
>  
> -        // static class store, thus gets not recreated, so ensure defaults are set!
> -        me.getStore().data.forEach(function (v) {
> -            v.state = '=';
> -        });
> -
>          me.value = me.originalValue = '';
> +        me.store.view = me;
>  
>          me.callParent(arguments);
>      },



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel