Re: [pve-devel] [PATCH qemu-server v2 06/16] qmp client: better abstract peer in preparation for qemu-storage-daemon

["Daniel Kral" <d.kral@proxmox.com>]

On Mon Oct 20, 2025 at 4:12 PM CEST, Fiona Ebner wrote:
> In preparation to add 'qsd' as a peer type for qemu-storage-daemon.
>
> There already are two different peer types, namely 'qga' for the QEMU
> guest agent and 'qmp' for the QEMU instance itself.
>
> Future QMP peers (like the qemu-storage-daemon) are likely to use a
> QMP monitor with capability negotiation like QEMU itself, so the
> special handling done for the guest agent stays limited to the 'qga'
> peer type.
>
> Replace the association with a VM ID and allow specifying an arbitrary
> ID.
>
> Precise two error messages that used a hard-coded 'qmp' by specifing
> the actual QMP peer type instead. The $peer structure also has a name
> that is used for error messages to avoid hard-coding 'VM' there.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Changes in v2:
> * Improve commit message.
> * Further abstract QMP peer in QMP client/monitor modules:
>   Replace 'vmid' by 'id' and allow specifying a peer name for error
>   messages. This is preparation for use cases of the storage daemon
>   where there might not be a single associated guest. For example,
>   restoring from a backup provider via exports of a storage daemon,
>   and a second storage daemon for the TPM of the VM itself.

Nice handling for the peer name!

Reviewed-by: Daniel Kral <d.kral@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel