[pve-devel] [PATCH pve-manager 1/1] api: apt: add 'all' option to Arch property

[pve-devel] [PATCH pve-manager 1/1] api: apt: add 'all' option to Arch property

[Nicolas Frey]

The `all` architecture is defined for e.g. all proxmox perl packages,
so add it to the enum.

This would lead to an error in the update view in PDM:
[...] failed to parse api response: unknown variant `all` [...]

Reported-by: Lukas Wagner <l.wagner@proxmox.com>
Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
 PVE/API2/APT.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
index 1ccbaf97..395ce070 100644
--- a/PVE/API2/APT.pm
+++ b/PVE/API2/APT.pm
@@ -204,7 +204,7 @@ my $apt_package_return_props = {
     Arch => {
         type => 'string',
         description => 'Package Architecture.',
-        enum => [qw(armhf arm64 amd64 ppc64el risc64 s390x)],
+        enum => [qw(armhf arm64 amd64 ppc64el risc64 s390x all)],
     },
     Description => {
         type => 'string',
-- 
2.47.3


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-manager 1/1] api: apt: add 'all' option to Arch property

[Lukas Wagner]

On Thu Nov 6, 2025 at 9:54 AM CET, Nicolas Frey wrote:
> The `all` architecture is defined for e.g. all proxmox perl packages,
> so add it to the enum.
>
> This would lead to an error in the update view in PDM:
> [...] failed to parse api response: unknown variant `all` [...]
>
> Reported-by: Lukas Wagner <l.wagner@proxmox.com>
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
>  PVE/API2/APT.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
> index 1ccbaf97..395ce070 100644
> --- a/PVE/API2/APT.pm
> +++ b/PVE/API2/APT.pm
> @@ -204,7 +204,7 @@ my $apt_package_return_props = {
>      Arch => {
>          type => 'string',
>          description => 'Package Architecture.',
> -        enum => [qw(armhf arm64 amd64 ppc64el risc64 s390x)],
> +        enum => [qw(armhf arm64 amd64 ppc64el risc64 s390x all)],
>      },
>      Description => {
>          type => 'string',

Looks good to me, thanks for the fix!

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel