From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Nicolas Frey" <n.frey@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager 1/1] api: apt: add 'all' option to Arch property
Date: Thu, 06 Nov 2025 10:13:33 +0100 [thread overview]
Message-ID: <DE1HW8VOWPIF.1OUKLHOODC1CH@proxmox.com> (raw)
In-Reply-To: <20251106085423.99138-1-n.frey@proxmox.com>
On Thu Nov 6, 2025 at 9:54 AM CET, Nicolas Frey wrote:
> The `all` architecture is defined for e.g. all proxmox perl packages,
> so add it to the enum.
>
> This would lead to an error in the update view in PDM:
> [...] failed to parse api response: unknown variant `all` [...]
>
> Reported-by: Lukas Wagner <l.wagner@proxmox.com>
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
> PVE/API2/APT.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
> index 1ccbaf97..395ce070 100644
> --- a/PVE/API2/APT.pm
> +++ b/PVE/API2/APT.pm
> @@ -204,7 +204,7 @@ my $apt_package_return_props = {
> Arch => {
> type => 'string',
> description => 'Package Architecture.',
> - enum => [qw(armhf arm64 amd64 ppc64el risc64 s390x)],
> + enum => [qw(armhf arm64 amd64 ppc64el risc64 s390x all)],
> },
> Description => {
> type => 'string',
Looks good to me, thanks for the fix!
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-11-06 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 8:54 Nicolas Frey
2025-11-06 9:13 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DE1HW8VOWPIF.1OUKLHOODC1CH@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=n.frey@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.