From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer v3 0/3] remove mirror selection from installer
Date: Tue, 04 Nov 2025 14:25:09 +0100 [thread overview]
Message-ID: <DDZXZS96E2UC.394I55ZAX5XV1@proxmox.com> (raw)
In-Reply-To: <20250922121103.206711-2-s.sterz@proxmox.com>
Applied the patches (fixing up patch #2 as needed) and built an ISO.
Checked that installation works fine and that /etc/apt/sources.list does
not get modified anymore.
Other than needing the rebase, please consider the series:
Reviewed-by: Christoph Heiss <c.heiss@proxmox.com>
Tested-by: Christoph Heiss <c.heiss@proxmox.com>
On Mon Sep 22, 2025 at 2:11 PM CEST, Shannon Sterz wrote:
> these three patches remove the debian mirror selection from the
> installer as it is no longer needed. debian recommends using its CDN
> these days [1]. so we don't need to select a mirror.
>
> [1]: https://www.debian.org/releases/trixie/release-notes/upgrading.en.html#adding-apt-internet-sources
>
> Changelog
> ---------
>
> changes since v2, thanks @ Christoph Heiss:
>
> - remove the mirror entries from
> `proxmox-auto-installer/tests/resources/locales.json`
>
> changes since v1, thanks @ Fiona Ebner:
>
> - add a patch that removes generating the mirror information from
> country.pl
> - add a patch rephrasing the installers text to remove mentions of
> selecting a mirror.
>
>
> Shannon Sterz (3):
> install: don't select a debian mirror based on the country anymore
> country.pl: remove generating mirror information
> html/country: update explanatory text to not mention setting a mirror
>
> Proxmox/Install.pm | 6 -
> country.pl | 12 +-
> html/country.htm | 9 +-
> .../tests/resources/locales.json | 249 ------------------
> 4 files changed, 5 insertions(+), 271 deletions(-)
>
> --
> 2.47.3
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-11-04 13:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 12:11 Shannon Sterz
2025-09-22 12:11 ` [pve-devel] [PATCH installer v3 1/3] install: don't select a debian mirror based on the country anymore Shannon Sterz
2025-09-22 12:11 ` [pve-devel] [PATCH installer v3 2/3] country.pl: remove generating mirror information Shannon Sterz
2025-11-04 12:29 ` Christoph Heiss
2025-09-22 12:11 ` [pve-devel] [PATCH installer v3 3/3] html/country: update explanatory text to not mention setting a mirror Shannon Sterz
2025-11-04 13:25 ` Christoph Heiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDZXZS96E2UC.394I55ZAX5XV1@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.