From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Cc: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v8 3/4] fix #1926 ui: vm console: autodetect novnc or xtermjs
Date: Mon, 27 Oct 2025 15:42:59 +0100 [thread overview]
Message-ID: <DDT6N0SBHWIE.1MJE7P2X9ZN0W@proxmox.com> (raw)
In-Reply-To: <20251003150045.3359961-4-a.lauterer@proxmox.com>
On Fri Oct 3, 2025 at 5:00 PM CEST, Aaron Lauterer wrote:
> @@ -474,7 +477,7 @@ Ext.define('PVE.qemu.Config', {
> lock = rec ? rec.data.value : undefined;
>
> spice = !!s.data.get('spice');
> - xtermjs = !!s.data.get('serial');
> + xtermjs = PVE.Utils.isSerialDisplay(s.data.get('display')?.data.value.type);
> }
>
> rec = s.data.get('tags');
> @@ -486,6 +489,10 @@ Ext.define('PVE.qemu.Config', {
>
> var resume = ['prelaunch', 'paused', 'suspended'].indexOf(qmpstatus) !== -1;
>
> + me.lookup('submenuConsoleBtn')?.loadConsole(xtermjs, 'kvm');
> +
> + statusTxt.update({ lock: lock });
> +
Might be that I'm just missing something, but why was this moved up
compared to v7? I don't think this is related to the rebase?
> if (resume || lock === 'suspended') {
> startBtn.setVisible(false);
> resumeBtn.setVisible(true);
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-10-27 14:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 15:00 [pve-devel] [PATCH qemu-server, manager v8 0/4] fix #1926 autodetect xtermjs or novnc for VM console Aaron Lauterer
2025-10-03 15:00 ` [pve-devel] [PATCH qemu-server v8 1/2] add new public get_default_vga_type function Aaron Lauterer
2025-10-03 15:00 ` [pve-devel] [PATCH qemu-server v8 2/2] api: status/current: add display property Aaron Lauterer
2025-10-03 15:00 ` [pve-devel] [PATCH manager v8 3/4] fix #1926 ui: vm console: autodetect novnc or xtermjs Aaron Lauterer
2025-10-27 14:42 ` Michael Köppl [this message]
2025-10-03 15:00 ` [pve-devel] [PATCH manager v8 4/4] ui: console: check on activate if display info for VMs is present Aaron Lauterer
2025-10-27 14:48 ` [pve-devel] [PATCH qemu-server, manager v8 0/4] fix #1926 autodetect xtermjs or novnc for VM console Michael Köppl
2025-11-03 21:04 ` Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDT6N0SBHWIE.1MJE7P2X9ZN0W@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=pve-devel-bounces@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.