From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Robert Obkircher" <r.obkircher@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-container 1/1] fix #6897: document that systemd requires nesting
Date: Wed, 22 Oct 2025 13:37:05 +0200 [thread overview]
Message-ID: <DDOTJYRURCTP.3BPY5KTA7UJA0@proxmox.com> (raw)
In-Reply-To: <20251022100937.25762-3-r.obkircher@proxmox.com>
On Wed Oct 22, 2025 at 12:03 PM CEST, Robert Obkircher wrote:
> Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
> ---
> src/PVE/LXC/Config.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
> index 5d3749e..bea09ef 100644
> --- a/src/PVE/LXC/Config.pm
> +++ b/src/PVE/LXC/Config.pm
> @@ -445,7 +445,7 @@ my $features_desc = {
> description => "Allow nesting."
> . " Best used with unprivileged containers with additional id mapping."
> . " Note that this will expose procfs and sysfs contents of the host"
> - . " to the guest.",
> + . " to the guest. That is also required by systemd to isolate services.",
nit: imo "This" would be more appropriate here than "That"
> },
> keyctl => {
> optional => 1,
Other than that small nit above:
Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-10-22 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 10:03 [pve-devel] [PATCH container/docs/manager 0/3] document that systemd requires LXC nesting Robert Obkircher
2025-10-22 10:03 ` [pve-devel] [PATCH pve-docs 1/1] fix #6897: " Robert Obkircher
2025-10-22 11:37 ` Shannon Sterz
2025-10-23 13:51 ` [pve-devel] applied: " Thomas Lamprecht
2025-10-22 10:03 ` [pve-devel] [PATCH pve-container 1/1] fix #6897: document that systemd requires nesting Robert Obkircher
2025-10-22 11:37 ` Shannon Sterz [this message]
2025-10-22 10:03 ` [pve-devel] [PATCH pve-manager 1/1] fix #6897: ui: add onlineHelp to lxc/FeaturesEdit Robert Obkircher
2025-10-22 11:37 ` Shannon Sterz
2025-10-23 14:44 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDOTJYRURCTP.3BPY5KTA7UJA0@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=r.obkircher@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.