From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Hannes Laimer" <h.laimer@proxmox.com>
Cc: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/3] ui: add 'unmount-on-done' field to SyncJobEdit window
Date: Tue, 14 Oct 2025 17:31:33 +0200 [thread overview]
Message-ID: <DDI5J4LA7LQX.RP8GJYQ8T3HQ@proxmox.com> (raw)
In-Reply-To: <20251014115357.81105-5-h.laimer@proxmox.com>
On Tue Oct 14, 2025 at 1:53 PM CEST, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> www/window/SyncJobEdit.js | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
> index 14ffddcd..00e6ed2e 100644
> --- a/www/window/SyncJobEdit.js
> +++ b/www/window/SyncJobEdit.js
> @@ -122,6 +122,7 @@ Ext.define('PBS.window.SyncJobEdit', {
> }
> if (!me.isCreate) {
> PBS.Utils.delete_if_default(values, 'run-on-mount', false);
> + PBS.Utils.delete_if_default(values, 'unmount-on-done', false);
> PBS.Utils.delete_if_default(values, 'rate-in');
> PBS.Utils.delete_if_default(values, 'rate-out');
> PBS.Utils.delete_if_default(values, 'remote');
> @@ -499,8 +500,30 @@ Ext.define('PBS.window.SyncJobEdit', {
> 'Run this job when a relevant removable datastore gets mounted.',
> ),
> },
> + listeners: {
> + change: function (field, runOnMount) {
> + let me = this;
> + let view = me.up('pbsSyncJobEdit');
> + let unmountOnDoneCb = view.down('field[name=unmount-on-done]');
> + unmountOnDoneCb.setDisabled(!runOnMount);
> + },
> + },
> + uncheckedValue: false,
> + value: false,
> + },
> + {
> + xtype: 'proxmoxcheckbox',
> + name: 'unmount-on-done',
> + fieldLabel: gettext('Unmount when done'),
> + autoEl: {
> + tag: 'div',
> + 'data-qtip': gettext(
> + 'Unmount relevant removable datastore onmce sync job finishes.',
got a typo there: once, not onmce :)
> + ),
> + },
> uncheckedValue: false,
> value: false,
> + disabled: true,
> },
> ],
> },
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-10-14 15:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 11:53 [pbs-devel] [PATCH proxmox{, -backup} 0/4] unmount datastores after sync job Hannes Laimer
2025-10-14 11:53 ` [pbs-devel] [PATCH proxmox 1/1] pbs-api-types: add 'unmount-on-done' field to sync job config Hannes Laimer
2025-10-14 11:53 ` [pbs-devel] [PATCH proxmox-backup 1/3] api: syncjob: correctly update/delete 'unmount-on-done' field Hannes Laimer
2025-10-14 11:53 ` [pbs-devel] [PATCH proxmox-backup 2/3] api: datastore: unmount datastore after sync if configured Hannes Laimer
2025-10-14 15:31 ` Shannon Sterz
2025-10-14 11:53 ` [pbs-devel] [PATCH proxmox-backup 3/3] ui: add 'unmount-on-done' field to SyncJobEdit window Hannes Laimer
2025-10-14 15:31 ` Shannon Sterz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDI5J4LA7LQX.RP8GJYQ8T3HQ@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.