Re: [yew-devel] [PATCH yew-comp 0/2] openid and default realm support in login panel

["Shannon Sterz" <s.sterz@proxmox.com>]

On Wed Oct 8, 2025 at 5:19 PM CEST, Shannon Sterz wrote:
> these patches add support for handling the default realm and openid
> login flow for the login panel.
>
> note that we already shipped the pve-yew-mobile-gui without support for
> openid login flows. so bumping that with this applied would be helpful
> for users that want to use the new mobile gui with an openid realm.
>

one small note about this: this patch series does not play as nicely
with the consent text implemented in the mobile gui as the desktop ui
does with its implementation. users would have to click the "OK" button
twice. once before starting the openid flow and a second time after
being redirected.

we could expose the helper that parses the search parameters in
`utils.rs`. then yew-mobile-gui could query the search parameters, if
they are there render the LoginPanel instead of showing the consent text
again. so more or less the same approach to the one we use in our
javascript front-ends. this would safe users from having to submit the
consent text twice.


also small note on that helper: while i could have used the url crate
[1] to parse the search parameters there, i already had the manual
approach outlined there implemented. since it saved me the hassle of
dealing with an extra `Result` i stuck to it. i can adapt this in a v2
if desired, though.

would still appreciate some feedback on the general approach used here.
thanks!

[1]: https://docs.rs/url/latest/url/struct.Url.html#method.query_pairs

> Shannon Sterz (2):
>   login_panel/realm_selector: use default realm provided by api
>   login_panel/realm_selector: add support for openid realm logins
>
>  src/login_panel.rs    | 327 +++++++++++++++++++++++++++++++++---------
>  src/realm_selector.rs |  85 ++++++++++-
>  2 files changed, 340 insertions(+), 72 deletions(-)
>
> --
> 2.47.3



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel