all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Cc: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager v2 0/2] ui: fix #6209: create snapshots and backups from context menu
Date: Fri, 03 Oct 2025 16:01:55 +0200	[thread overview]
Message-ID: <DD8QQIGOU3P7.3CS3UOB2JKTU0@proxmox.com> (raw)
In-Reply-To: <20251002151609.41473-1-n.frey@proxmox.com>

Applied this patch series and tested the changes. 

Verfied The Following:
- Confirmed the right-click context menu now shows both "Take
  Snapshot" and "Backup now" options. 
- Clicking on the options show the backup and snapshots dialog. 
- Took snapshots for VMs and CTs
- Ran manual PBS backups for a VM and a CT. 
- The snapshot window extra curly brace is also not visible anymore. 

Tested-by: Shan Shaji <s.shaji@proxmox.com>

On Thu Oct 2, 2025 at 5:16 PM CEST, Nicolas Frey wrote:
> This patch series adds functionality to take snapshots and create
> manual backups of VMs and CTs through the right-click context menu.
>
> The original feature request [0] only specified the ability to take
> snapshots. I added the manual backup shortcut as well, since
> navigating through the menu for this action felt unnecessarily
> cumbersome when performing just a quick backup. LMK if that is a
> useful addition.
>
> changes since v1, thanks @Fiona Ebner
> * clarified commit message
> * addressed several issues in the added menu options, namely:
>   * correctly handle disabled state with async
>   * fixed negation logic and cleaned up minor nits
>
> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=6209
>
> Nicolas Frey (2):
>   ui: guest snapshot: remove excess '}' at the end of window title
>   ui: fix #6209: create snapshots and backups from context menu
>
>  www/manager6/lxc/CmdMenu.js     | 47 +++++++++++++++++++++++++++++++++
>  www/manager6/qemu/CmdMenu.js    | 47 +++++++++++++++++++++++++++++++++
>  www/manager6/window/Snapshot.js |  2 +-
>  3 files changed, 95 insertions(+), 1 deletion(-)



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-10-03 14:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-02 15:16 Nicolas Frey
2025-10-02 15:16 ` [pve-devel] [PATCH pve-manager v2 1/2] ui: guest snapshot: remove excess '}' at the end of window title Nicolas Frey
2025-10-03 17:31   ` [pve-devel] applied: " Thomas Lamprecht
2025-10-02 15:16 ` [pve-devel] [PATCH pve-manager v2 2/2] ui: fix #6209: create snapshots and backups from context menu Nicolas Frey
2025-10-03 14:01 ` Shan Shaji [this message]
2025-10-07  8:56 ` [pve-devel] [PATCH pve-manager v2 0/2] " Nicolas Frey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DD8QQIGOU3P7.3CS3UOB2JKTU0@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pve-devel-bounces@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal