From: "Daniel Kral" <d.kral@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Cc: pve-devel <pve-devel-bounces@lists.proxmox.com>,
Thomas Skinner <thomas@atskinner.net>
Subject: Re: [pve-devel] [PATCH SERIES docs/ha-manager/manager v2] close #6144: add ui button + api for node maintenance mode
Date: Thu, 02 Oct 2025 13:53:19 +0200 [thread overview]
Message-ID: <DD7TDHY35996.1I8Q9ZQIOQAKD@proxmox.com> (raw)
In-Reply-To: <20250920182050.1657928-1-thomas@atskinner.net>
On Sat Sep 20, 2025 at 8:20 PM CEST, Thomas Skinner wrote:
> Continued work on node maintenance mode button in UI.
>
> Changes since V1:
> - Code refactoring/reformatting
> - Clarity in docs
> - Remove redundant GET API for maintenance status
> - Change button UI to dropdown menu with icons
Sorry for the wait on a review for this..
Thanks for the v2, works as expected and apart from the inline note
about the permission it looks good to me.
I think it was be better to have a single Enable/Disable toggle button
instead of a dropdown if there's no current development to add more
maintenance modes to HA LRMs, but I don't want to be nitpicky about
this, so with the permission note resolved consider this as:
Reviewed-by: Daniel Kral <d.kral@proxmox.com>
Tested-by: Daniel Kral <d.kral@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-10-02 11:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-20 18:20 Thomas Skinner
2025-09-20 18:20 ` [pve-devel] [PATCH ha-manager v2 1/1] add additional api field for lrm_mode in status check Thomas Skinner
2025-09-20 18:20 ` [pve-devel] [PATCH manager v2 1/2] add api setter for node maintenance mode Thomas Skinner
2025-10-02 11:47 ` Daniel Kral
2025-09-20 18:20 ` [pve-devel] [PATCH docs v2 1/1] add docs for maintenance mode buttons in UI Thomas Skinner
2025-09-20 18:20 ` [pve-devel] [PATCH manager v2 2/2] add UI for node maintenance enable/disable Thomas Skinner
2025-10-02 11:53 ` Daniel Kral [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DD7TDHY35996.1I8Q9ZQIOQAKD@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel-bounces@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=thomas@atskinner.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.