Re: [pve-devel] [PATCH widget-toolkit v2 1/1] window: add ConfirmRemoveDialog

["Michael Köppl" <m.koeppl@proxmox.com>]

On Fri Sep 26, 2025 at 4:15 PM CEST, Daniel Kral wrote:
> I think it's a good idea to combine these, but at the same time it's a
> bit hard to review not seeing the diff from Proxmox.window.SafeDestroy
> here directly..
>
> I diffed them locally and if it's not too much work, it might be nice to
> adapt Proxmox.window.SafeDestroy and set dangerous = true there by
> default and only set dangerous = false for the special case in
> ConfirmRemoveResource / SafeDestroyResource, but that might also be just
> nit-picking from my side.
>
> What do you think?

Thanks for having a look and the feedback! Do you mean that SafeDestroy
should extend ConfirmRemoveDialog and set dangerous = true, or should
ConfirmRemoveDialog still replace SafeDestroy, but with dangerous = true
as the default? I wasn't quite sure regarding what the default should
be, but I avoided adding an additional layer (as in:
ConfirmRemoveDialog -> SafeDestroy ->
{SafeDestroyGuest,SafeDestroyStorage}) because I feld that made it a lot
more complicated than it needs to be.


>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel