From: "Daniel Kral" <d.kral@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Cc: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH FOLLOW-UP manager 1/1] ui: replace SafeDestroy with ConfirmRemoveDialog
Date: Fri, 26 Sep 2025 16:08:00 +0200 [thread overview]
Message-ID: <DD2SHCWK7DD0.336B3IGXYIUC@proxmox.com> (raw)
In-Reply-To: <20250924161714.434858-3-m.koeppl@proxmox.com>
On Wed Sep 24, 2025 at 6:17 PM CEST, Michael Köppl wrote:
> The ConfirmRemoveDialog offers additional customization, but covers
> SafeDestroy's feature set. This is done mostly to streamline the
> implementation, basing dialogs to remove guests, storage, or resources
> on the same component.
>
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
SafeDestroy is also used in the PBS' web interface, so it should be
adapted there too:
```
$ rg "(Proxmox\.window\.SafeDestroy|proxmoxSafeDestroy)" -tjs .
./pve/proxmox-widget-toolkit/src/window/SafeDestroy.js
3:Ext.define('Proxmox.window.SafeDestroy', {
5: alias: 'widget.proxmoxSafeDestroy',
./pve/pve-manager/www/manager6/ceph/Pool.js
528: Ext.create('Proxmox.window.SafeDestroy', {
./pve/pve-manager/www/manager6/storage/ImageView.js
63: var win = Ext.create('Proxmox.window.SafeDestroy', {
./pve/pve-manager/www/manager6/window/SafeDestroyGuest.js
5: extend: 'Proxmox.window.SafeDestroy',
./pve/pve-manager/www/manager6/window/SafeDestroyStorage.js
5: extend: 'Proxmox.window.SafeDestroy',
./rust/proxmox-backup/www/DirectoryList.js
43: Ext.create('Proxmox.window.SafeDestroy', {
./rust/proxmox-backup/www/datastore/Content.js
650: Ext.create('Proxmox.window.SafeDestroy', {
./rust/proxmox-backup/www/datastore/OptionView.js
2: extend: 'Proxmox.window.SafeDestroy',
./rust/proxmox-backup/www/window/NamespaceEdit.js
56: extend: 'Proxmox.window.SafeDestroy',
77: let win = field.up('proxmoxSafeDestroy');
```
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-09-26 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 16:17 [pve-devel] [PATCH FOLLOW-UP manager/widget-toolkit 0/2] replace SafeDestroy Michael Köppl
2025-09-24 16:17 ` [pve-devel] [PATCH FOLLOW-UP widget-toolkit 1/1] window: remove SafeDestroy Michael Köppl
2025-09-24 16:17 ` [pve-devel] [PATCH FOLLOW-UP manager 1/1] ui: replace SafeDestroy with ConfirmRemoveDialog Michael Köppl
2025-09-26 14:08 ` Daniel Kral [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DD2SHCWK7DD0.336B3IGXYIUC@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel-bounces@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.