Re: [pmg-devel] [PATCH pmg-api v2 2/2] templates: fetchmail: add comment where users can add manual accounts

["Max R. Carrara" <m.carrara@proxmox.com>]

On Wed Sep 24, 2025 at 8:05 PM CEST, Stoiko Ivanov wrote:
> our fetchmail module uses /etc/fetchmailrc (symlinked to
> /etc/pmg/fetchmailrc) as authoritative source for fetchmail accounts.
>
> This means that if users need to make adaptations to fetchmail options
> it breaks the handling of fetchmail in the API and GUI.
>
> based on feedback from #6798 I think providing a hint where users
> can add accounts with manual overrides, while keeping the API/GUI
> working for all other accounts should help.
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  src/templates/fetchmailrc.tt | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/templates/fetchmailrc.tt b/src/templates/fetchmailrc.tt
> index 76e591ca..f7f341de 100644
> --- a/src/templates/fetchmailrc.tt
> +++ b/src/templates/fetchmailrc.tt
> @@ -9,6 +9,9 @@ defaults:
>  
>  smtphost [% ipconfig.int_ip %]/[% pmg.mail.ext_port %]
>  
> +# add manually configured accounts below and before 'proxmox settings'(to keep the UI working)

Small nit: would add a space after 'proxmox settings' above, so the
parenthesis isn't glued to it:

  add manually configured accounts below and before 'proxmox settings' (to keep the UI working)

Alternatively, the text in parentheses can also go to be fair; users
don't necessarily need to know up front that the UI will break if they
edit the wrong parts of the file, IMO.

> +
> +
>  # proxmox settings (Do not delete this marker!!)
>  [% FOREACH item IN fetchmail_users.list('values') %]
>  [% IF item.enable %]poll[% ELSE %]skip[% END -%]



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel