From: "Shannon Sterz" <s.sterz@proxmox.com>
To: <pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager/proxmox/yew-comp 00/11] Add LDAP and AD realm support to Proxmox Datacenter Manager
Date: Mon, 22 Sep 2025 15:58:08 +0200 [thread overview]
Message-ID: <DCZDLVQC9V6B.30GUQRQFGXCX6@proxmox.com> (raw)
In-Reply-To: <DCWQCFGTKJAO.3V4K453HVRPO4@proxmox.com>
one more thing:
On Fri Sep 19, 2025 at 1:11 PM CEST, Shannon Sterz wrote:
> On Fri Sep 19, 2025 at 12:02 PM CEST, Christoph Heiss wrote:
-->8 snip 8<--
>> - PVE/PBS have the ability to also sync the `comment` field from some
>> attribute (e.g. `sync-attributes comment=userPrincipal`), for PDM
>> this currently is not allowed by the schema. But this can be part of a
>> future improvement IMO.
>
> will take a look at this as well, must have missed that as it wasn't
> exposed in the ui.
did that now, but this is not actually something pbs supports. looking
at the sync logic [1] comments are only preserved, not synced from the
realm.
the SyncAttributes schema also does not have a `Comment` variant [2].
so i think for now getting the existing logic into a common crate takes
precedence over implementing feature parity with pve imo. meaning, i'll
leave this as a follow up.
[1]: https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=src/server/realm_sync_job.rs;h=8768a0d80fcfda10dc7e1549592556b1ccc6f347;hb=HEAD#l295
[2]: https://git.proxmox.com/?p=proxmox.git;a=blob;f=pbs-api-types/src/ldap.rs;h=5114616055bca1e032c4222cff8b0047ca6bb514;hb=HEAD#l180
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-09-22 13:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 14:48 Shannon Sterz
2025-09-16 14:48 ` [pdm-devel] [PATCH proxmox 1/1] ldap: add types and sync features Shannon Sterz
2025-09-16 14:48 ` [pdm-devel] [PATCH yew-comp 1/5] auth_view: add default column and allow setting ldap realms as default Shannon Sterz
2025-09-16 14:48 ` [pdm-devel] [PATCH yew-comp 2/5] utils: add pdm realm to `get_auth_domain_info` Shannon Sterz
2025-09-16 14:48 ` [pdm-devel] [PATCH yew-comp 3/5] auth_view/auth_edit_ldap: add support for active directory realms Shannon Sterz
2025-09-16 14:48 ` [pdm-devel] [PATCH yew-comp 4/5] auth_edit_ldap: add helpers to properly edit ad & ldap realms Shannon Sterz
2025-09-16 14:48 ` [pdm-devel] [PATCH yew-comp 5/5] auth_view: implement syncing ldap and ad realms Shannon Sterz
2025-09-16 14:48 ` [pdm-devel] [PATCH datacenter-manager 1/5] config: add domain config plugins for " Shannon Sterz
2025-09-16 14:48 ` [pdm-devel] [PATCH datacenter-manager 2/5] server: add ldap and active directory authenticators Shannon Sterz
2025-09-16 14:48 ` [pdm-devel] [PATCH datacenter-manager 3/5] server: api: add api endpoints for configuring ldap & ad realms Shannon Sterz
2025-09-16 14:48 ` [pdm-devel] [PATCH datacenter-manager 4/5] api/auth: add endpoint to start ldap sync jobs Shannon Sterz
2025-09-16 14:48 ` [pdm-devel] [PATCH datacenter-manager 5/5] ui: add a panel to allow handling realms Shannon Sterz
2025-09-19 10:02 ` [pdm-devel] [PATCH datacenter-manager/proxmox/yew-comp 00/11] Add LDAP and AD realm support to Proxmox Datacenter Manager Christoph Heiss
2025-09-22 13:55 ` Shannon Sterz
2025-09-22 13:57 ` Shannon Sterz
2025-09-22 13:58 ` Shannon Sterz [this message]
2025-09-22 15:06 ` [pdm-devel] Superseded: " Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCZDLVQC9V6B.30GUQRQFGXCX6@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.